Make 'transform' a presentation attribute on SVG elements

third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp

 /*
  * Copyright (C) Research In Motion Limited 2011-2012. All rights reserved.
  * Copyright (C) 2013 Samsung Electronics. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 34 matching lines @@
   m_type = AnimatedUnknown;
   m_cssProperty = CSSPropertyInvalid;
 }
 
 void SVGAnimatedTypeAnimator::reset(const SVGElement& contextElement) {
   const QualifiedName& attributeName = m_animationElement->attributeName();
   m_animatedProperty = contextElement.propertyFromAttribute(attributeName);
   if (m_animatedProperty) {
     m_type = m_animatedProperty->type();
     m_cssProperty = m_animatedProperty->cssPropertyId();
+
+    if (m_type == AnimatedTransformList) {
+      // Only <animateTransform> is allowed to animate AnimatedTransformList.
+      // http://www.w3.org/TR/SVG/animate.html#AnimationAttributesAndProperties
+      if (!isSVGAnimateTransformElement(*m_animationElement))
+        m_type = AnimatedUnknown;
+      // Because of the syntactic mismatch between the CSS and SVGProperty
+      // representations, disallow CSS animations of transform list for
+      // now. (We also reject this case via
+      // SVGAnimateTransformElement::hasValidAttributeType ATM.)
+      m_cssProperty = CSSPropertyInvalid;
+    }
   } else {
     m_type = SVGElement::animatedPropertyTypeForCSSAttribute(attributeName);
     m_cssProperty = m_type != AnimatedUnknown
                         ? cssPropertyID(attributeName.localName())
                         : CSSPropertyInvalid;
-  }
-
-  // Only <animateTransform> is allowed to animate AnimatedTransformList.
-  // http://www.w3.org/TR/SVG/animate.html#AnimationAttributesAndProperties
-  if (m_type == AnimatedTransformList &&
-      !isSVGAnimateTransformElement(*m_animationElement)) {
-    m_type = AnimatedUnknown;
-    m_cssProperty = CSSPropertyInvalid;
+    DCHECK_NE(m_type, AnimatedTransformList);
   }
 
   DCHECK(m_type != AnimatedPoint && m_type != AnimatedStringList &&
          m_type != AnimatedTransform);
 }
 
 SVGPropertyBase* SVGAnimatedTypeAnimator::createPropertyForAttributeAnimation(
     const String& value) const {
   // SVG DOM animVal animation code-path.
   if (m_type == AnimatedTransformList) {
@@ skipping 79 matching lines @@
   DCHECK_EQ(animatedValue->type(), m_type);
   return animatedValue;
 }
 
 DEFINE_TRACE(SVGAnimatedTypeAnimator) {
   visitor->trace(m_animationElement);
   visitor->trace(m_animatedProperty);
 }
 
 }  // namespace blink