Make 'transform' a presentation attribute on SVG elements

third_party/WebKit/Source/core/svg/SVGElement.h

 /*
  * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
  * Copyright (C) 2009, 2014 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 56 matching lines @@
   bool hasTagName(const SVGQualifiedName& name) const {
     return hasLocalName(name.localName());
   }
 
   String title() const override;
   bool hasRelativeLengths() const {
     return !m_elementsWithRelativeLengths.isEmpty();
   }
   static bool isAnimatableCSSProperty(const QualifiedName&);
 
+  bool hasTransform() const;

[pdr., 2016/11/22 04:02:48]

hasTransform and hasAnimatedLocalTransform are pretty similar. Is there a way to
make their differenced more clear?

[fs, 2016/11/22 13:54:07]

I guess we could consider renaming the "...AnimatedLocal..." methods to be more
about including the "motion transform" contribution.
Another option would be to just fold the "motion transform" application into
these two, and then have a "IncludeMotionTransform" enumeration argument a'la
the ComputedStyle method? (I think that would trade one vcall for another, so
hopefully not an issue from that PoV.)

[fs, 2016/11/22 14:01:24]

(Appears I mistakenly thought one of the "...AnimatedLocal..." methods was
virtual, but that was not the case.)

[fs, 2016/11/22 14:54:35]

PS8 contains something along the lines of the latter suggestion.

+  AffineTransform calculateTransform() const;
+
   enum CTMScope {
     NearestViewportScope,  // Used by SVGGraphicsElement::getCTM()
     ScreenScope,           // Used by SVGGraphicsElement::getScreenCTM()
     AncestorScope  // Used by SVGSVGElement::get{Enclosure|Intersection}List()
   };
   virtual AffineTransform localCoordinateSpaceTransform(CTMScope) const;
   virtual bool needsPendingResourceHandling() const { return true; }
 
   bool instanceUpdatesBlocked() const;
   void setInstanceUpdatesBlocked(bool);
@@ skipping 257 matching lines @@
   inline bool isElementOfType<const thisType>(const SVGElement& element) { \
     return is##thisType(element);                                          \
   }                                                                        \
   DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(thisType)
 
 }  // namespace blink
 
 #include "core/SVGElementTypeHelpers.h"
 
 #endif  // SVGElement_h