Lock profile before sign in when force sign in is enabled.

chrome/browser/profiles/profile_attributes_entry.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-
+//
+#include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile_attributes_entry.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
+#include "chrome/common/pref_names.h"
+#include "components/prefs/pref_service.h"
+
+namespace {
+bool IsForceSigninEnabled() {
+  PrefService* prefs = g_browser_process->local_state();
+  return prefs && prefs->GetBoolean(prefs::kForceBrowserSignin);
+}
+}  // namespace
 
 ProfileAttributesEntry::ProfileAttributesEntry()
-    : profile_info_cache_(nullptr),
-      profile_path_(base::FilePath()) {}
+    : profile_info_cache_(nullptr), profile_path_(base::FilePath()) {}
 
 void ProfileAttributesEntry::Initialize(
     ProfileInfoCache* cache, const base::FilePath& path) {
   DCHECK(!profile_info_cache_);
   DCHECK(cache);
   profile_info_cache_ = cache;
   DCHECK(profile_path_.empty());
   DCHECK(!path.empty());
   profile_path_ = path;
+  is_force_signin_enabled_ = IsForceSigninEnabled();

[Roger Tawa OOO till Jul 10th, 2016/11/08 15:16:11]

Do you really need to save IsForceSigninEnabled() in a member?  Seems like you
could just call IsForceSigninEnabled() each time you needed it.  Is
LockForceSigninProfile() a function that is called often and is performance
critical?

[zmin, 2016/11/08 18:39:07]

force_signin flag will be checked every time the SetIsSigninRequired get called.

+  if (!IsAuthenticated() && is_force_signin_enabled_)
+    is_force_signin_profile_locked_ = true;
 }
 
 base::string16 ProfileAttributesEntry::GetName() const {
   return profile_info_cache_->GetNameOfProfileAtIndex(profile_index());
 }
 
 base::string16 ProfileAttributesEntry::GetShortcutName() const {
   return profile_info_cache_->GetShortcutNameOfProfileAtIndex(profile_index());
 }
 
@@ skipping 59 matching lines @@
 
 bool ProfileAttributesEntry::IsLegacySupervised() const {
   return profile_info_cache_->ProfileIsLegacySupervisedAtIndex(profile_index());
 }
 
 bool ProfileAttributesEntry::IsOmitted() const {
   return profile_info_cache_->IsOmittedProfileAtIndex(profile_index());
 }
 
 bool ProfileAttributesEntry::IsSigninRequired() const {
-  return profile_info_cache_->ProfileIsSigninRequiredAtIndex(profile_index());
+  return profile_info_cache_->ProfileIsSigninRequiredAtIndex(profile_index()) ||
+         is_force_signin_profile_locked_;
 }
 
 std::string ProfileAttributesEntry::GetSupervisedUserId() const {
   return profile_info_cache_->GetSupervisedUserIdOfProfileAtIndex(
       profile_index());
 }
 
 bool ProfileAttributesEntry::IsEphemeral() const {
   return profile_info_cache_->ProfileIsEphemeralAtIndex(profile_index());
 }
@@ skipping 106 matching lines @@
   profile_info_cache_->SetGAIAPictureOfProfileAtIndex(profile_index(), image);
 }
 
 void ProfileAttributesEntry::SetIsUsingGAIAPicture(bool value) {
   profile_info_cache_->SetIsUsingGAIAPictureOfProfileAtIndex(
       profile_index(), value);
 }
 
 void ProfileAttributesEntry::SetIsSigninRequired(bool value) {
   profile_info_cache_->SetProfileSigninRequiredAtIndex(profile_index(), value);
+  LockForceSigninProfile(value);
+}
+
+void ProfileAttributesEntry::LockForceSigninProfile(bool is_lock) {
+  if (is_force_signin_enabled_)

[Roger Tawa OOO till Jul 10th, 2016/11/08 15:16:11]

Should this be a DCHECK instead of if statement?

[zmin, 2016/11/08 18:39:07]

SetIsSigninRequired() will call LockForceSigninProfile().

I'll move the if statement to SetIsSigninRequired() and add the DCHECK here. I
think it makes more sense.

+    is_force_signin_profile_locked_ = is_lock;
 }
 
 void ProfileAttributesEntry::SetIsEphemeral(bool value) {
   profile_info_cache_->SetProfileIsEphemeralAtIndex(profile_index(), value);
 }
 
 void ProfileAttributesEntry::SetIsUsingDefaultName(bool value) {
   profile_info_cache_->SetProfileIsUsingDefaultNameAtIndex(
       profile_index(), value);
 }
@@ skipping 35 matching lines @@
     const std::string& gaia_id, const base::string16& user_name) {
   profile_info_cache_->SetAuthInfoOfProfileAtIndex(
       profile_index(), gaia_id, user_name);
 }
 
 size_t ProfileAttributesEntry::profile_index() const {
   size_t index = profile_info_cache_->GetIndexOfProfileWithPath(profile_path_);
   DCHECK(index < profile_info_cache_->GetNumberOfProfiles());
   return index;
 }