Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 2478163002: Fix potential flakiness in PrerenderBrowserTest.AutosigninInPrerenderer (Closed)
Patch Set: Remove comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_browsertest.cc
diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc
index 31ee3cb6beb5616397b0f6e8f78c4bacc15c360b..8f4dbe09173d4ee5dfa386001409ccfb2fc73f57 100644
--- a/chrome/browser/prerender/prerender_browsertest.cc
+++ b/chrome/browser/prerender/prerender_browsertest.cc
@@ -3250,9 +3250,9 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, AutosigninInPrerenderer) {
base::Bind(&CreateCountingInterceptorOnIO,
done_url, empty_file, done_counter.AsWeakPtr()));
// Loading may finish or be interrupted. The final result is important only.
- // TODO(http://crbug.com/660278): TestPrrenderContents can be created after
- // the JS code runs. The result would be a test timeout.
DisableLoadEventCheck();
+ // TestPrenderContents is always created before the Autosignin JS can run, so
+ // waiting for PrerenderContents to stop should be reliable.
PrerenderTestURL("/password/autosignin.html",
FINAL_STATUS_CREDENTIAL_MANAGER_API, 0);
EXPECT_EQ(0, done_counter.count());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698