tests_lit/llvm2ice_tests/test_i1.ll - Issue 2478113003: [SubZero] Utilize instructions with immediate operands

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests_lit/llvm2ice_tests/test_i1.ll

Issue 2478113003: [SubZero] Utilize instructions with immediate operands (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Addressed review comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests_lit/llvm2ice_tests/test_i1.ll

diff --git a/tests_lit/llvm2ice_tests/test_i1.ll b/tests_lit/llvm2ice_tests/test_i1.ll

index 70558c5026615e30bc355bb0d3aeb12e73d9f481..13d6b517f89ca13644aed60db969dea9288441fc 100644

--- a/tests_lit/llvm2ice_tests/test_i1.ll

+++ b/tests_lit/llvm2ice_tests/test_i1.ll

@@ -34,8 +34,7 @@ entry:

; ARM32-LABEL: testAndTrue

; ARM32: and {{.*}}, #1

; MIPS32-LABEL: testAndTrue

-; MIPS32: li [[REG:.*]],1

-; MIPS32: and {{.*}},[[REG]]

+; MIPS32: andi {{.*}},0x1

; Test that or with true uses immediate 1, not -1.

define internal i32 @testOrTrue(i32 %arg) {

@@ -50,8 +49,7 @@ entry:

; ARM32-LABEL: testOrTrue

; ARM32: orr {{.*}}, #1

; MIPS32-LABEL: testOrTrue

-; MIPS32: li [[REG:.*]],1

-; MIPS32: or {{.*}},[[REG]]

+; MIPS32: ori {{.*}},0x1

; Test that xor with true uses immediate 1, not -1.

define internal i32 @testXorTrue(i32 %arg) {

@@ -66,8 +64,7 @@ entry:

; ARM32-LABEL: testXorTrue

; ARM32: eor {{.*}}, #1

; MIPS32-LABEL: testXorTrue

-; MIPS32: li [[REG:.*]],1

-; MIPS32: xor {{.*}},[[REG]]

+; MIPS32: xori {{.*}},0x1

; Test that trunc to i1 masks correctly.

define internal i32 @testTrunc(i32 %arg) {

« no previous file with comments | « tests_lit/llvm2ice_tests/switch-opt.ll ('k') | tests_lit/llvm2ice_tests/uncond_br.ll » ('j') | no next file with comments »