[SubZero] Utilize instructions with immediate operands

tests_lit/assembler/mips32/encoding_test_arith.ll

Index: tests_lit/assembler/mips32/encoding_test_arith.ll
diff --git a/tests_lit/assembler/mips32/encoding_test_arith.ll b/tests_lit/assembler/mips32/encoding_test_arith.ll
index 223bc7d61d5a7eba596713abbb66dc12854d614a..eb8266ea0a4c93cf0188003729805257034fce51 100644
--- a/tests_lit/assembler/mips32/encoding_test_arith.ll
+++ b/tests_lit/assembler/mips32/encoding_test_arith.ll
@@ -32,68 +32,40 @@ define internal i32 @test_01(i32 %a) {
 
 ; ASM-LABEL: test_01:
 ; ASM-NEXT: .Ltest_01$__0:
-; ASM-NEXT:	# $zero = def.pseudo
-; ASM-NEXT:	addiu	$v0, $zero, 1
-; ASM-NEXT:	addu	$a0, $a0, $v0
-; ASM-NEXT:	# $zero = def.pseudo
-; ASM-NEXT:	addiu	$v0, $zero, 1
-; ASM-NEXT:	and	$a0, $a0, $v0
-; ASM-NEXT:	# $zero = def.pseudo
-; ASM-NEXT:	addiu	$v0, $zero, 1
-; ASM-NEXT:	or	$a0, $a0, $v0
-; ASM-NEXT:	# $zero = def.pseudo
-; ASM-NEXT:	addiu	$v0, $zero, 1
-; ASM-NEXT:	xor	$a0, $a0, $v0
+; ASM-NEXT:	addiu	$a0, $a0, 1
+; ASM-NEXT:	andi	$a0, $a0, 1
+; ASM-NEXT:	ori	$a0, $a0, 1
+; ASM-NEXT:	xori	$a0, $a0, 1
 ; ASM-NEXT:	move	$v0, $a0
 ; ASM-NEXT:	jr	$ra
 
 ; DIS-LABEL:00000000 <test_01>:
-; DIS-NEXT:   0:   24020001	li	v0,1
-; DIS-NEXT:   4:   00822021	addu	a0,a0,v0
-; DIS-NEXT:   8:   24020001	li	v0,1
-; DIS-NEXT:   c:   00822024	and	a0,a0,v0
-; DIS-NEXT:  10:   24020001	li	v0,1
-; DIS-NEXT:  14:   00822025	or	a0,a0,v0
-; DIS-NEXT:  18:   24020001	li	v0,1
-; DIS-NEXT:  1c:   00822026	xor	a0,a0,v0
-; DIS-NEXT:  20:   00801021	move	v0,a0
-; DIS-NEXT:  24:   03e00008	jr	ra
-; DIS-NEXT:  28:   00000000	nop
+; DIS-NEXT:   0:	24840001 	addiu	a0,a0,1
+; DIS-NEXT:   4:	30840001 	andi	a0,a0,0x1
+; DIS-NEXT:   8:	34840001 	ori	a0,a0,0x1
+; DIS-NEXT:   c:	38840001 	xori	a0,a0,0x1
+; DIS-NEXT:  10:	00801021 	move	v0,a0
+; DIS-NEXT:  14:	03e00008 	jr	ra
+; DIS-NEXT:  18:	00000000 	nop
 
 ; IASM-LABEL: test_01:
 ; IASM-LABEL: .Ltest_01$__0:
 ; IASM-NEXT:	.byte 0x1
 ; IASM-NEXT:	.byte 0x0
-; IASM-NEXT:	.byte 0x2
+; IASM-NEXT:	.byte 0x84
 ; IASM-NEXT:	.byte 0x24
-; IASM-NEXT:	.byte 0x21
-; IASM-NEXT:	.byte 0x20
-; IASM-NEXT:	.byte 0x82
-; IASM-NEXT:	.byte 0x0
 ; IASM-NEXT:	.byte 0x1
 ; IASM-NEXT:	.byte 0x0
-; IASM-NEXT:	.byte 0x2
-; IASM-NEXT:	.byte 0x24
-; IASM-NEXT:	.byte 0x24
-; IASM-NEXT:	.byte 0x20
-; IASM-NEXT:	.byte 0x82
-; IASM-NEXT:	.byte 0x0
+; IASM-NEXT:	.byte 0x84
+; IASM-NEXT:	.byte 0x30
 ; IASM-NEXT:	.byte 0x1
 ; IASM-NEXT:	.byte 0x0
-; IASM-NEXT:	.byte 0x2
-; IASM-NEXT:	.byte 0x24
-; IASM-NEXT:	.byte 0x25
-; IASM-NEXT:	.byte 0x20
-; IASM-NEXT:	.byte 0x82
-; IASM-NEXT:	.byte 0x0
+; IASM-NEXT:	.byte 0x84
+; IASM-NEXT:	.byte 0x34
 ; IASM-NEXT:	.byte 0x1
 ; IASM-NEXT:	.byte 0x0
-; IASM-NEXT:	.byte 0x2
-; IASM-NEXT:	.byte 0x24
-; IASM-NEXT:	.byte 0x26
-; IASM-NEXT:	.byte 0x20
-; IASM-NEXT:	.byte 0x82
-; IASM-NEXT:	.byte 0x0
+; IASM-NEXT:	.byte 0x84
+; IASM-NEXT:	.byte 0x38
 ; IASM-NEXT:	.byte 0x21
 ; IASM-NEXT:	.byte 0x10
 ; IASM-NEXT:	.byte 0x80
@@ -123,14 +95,14 @@ define internal i32 @test_02(i32 %a) {
 ; ASM-NEXT:	move	$v0, $a0
 ; ASM-NEXT:	jr	$ra
 
-; DIS-LABEL:00000030 <test_02>:
-; DIS-NEXT:  30:   24020009	li	v0,9
-; DIS-NEXT:  34:   00822026	xor	a0,a0,v0
-; DIS-NEXT:  38:   2c840001	sltiu	a0,a0,1
-; DIS-NEXT:  3c:   30840001	andi	a0,a0,0x1
-; DIS-NEXT:  40:   00801021	move	v0,a0
-; DIS-NEXT:  44:   03e00008	jr	ra
-; DIS-NEXT:  48:   00000000	nop
+; DIS-LABEL:00000020 <test_02>:

[Jim Stichnoth, 2016/11/04 13:18:48]

This is unfortunate - i.e., changes to an unrelated test affect this test's
output, just because of hard-coded code addresses.  Several other files in the
assembler/mips32/ directory may suffer from that in the future.

I see two ways to deal with this:

1. Just remove the code address offsets from the check strings, such as is done
in encoding_intrinsics.ll.

2. Add -ffunction-sections to the pnacl-sz args for all the RUN commands, or at
least those with --check-prefix=DIS.

It's OK to leave things as you have them for this CL, but you might want to
consider a separate cleanup CL to reduce future pain.

[jaydeep.patil, 2016/11/07 03:55:11]

I will submit a separate cleanup CL.

+; DIS-NEXT:   20:	24020009 	li	v0,9
+; DIS-NEXT:   24:	00822026 	xor	a0,a0,v0
+; DIS-NEXT:   28:	2c840001 	sltiu	a0,a0,1
+; DIS-NEXT:   2c:	30840001 	andi	a0,a0,0x1
+; DIS-NEXT:   30:	00801021 	move	v0,a0
+; DIS-NEXT:   34:	03e00008 	jr	ra
+; DIS-NEXT:   38:	00000000 	nop
 
 ; IASM-LABEL: test_02:
 ; IASM-LABEL: .Ltest_02$__0:
@@ -182,15 +154,19 @@ entry:
 
 ; IASM-LABEL: ashrImm:
 ; IASM-NEXT: .LashrImm$entry:
-; IASM-NEXT: 	.byte 0x7
-; IASM-NEXT: 	.byte 0x20
-; IASM-NEXT: 	.byte 0xa4
-; IASM-NEXT: 	.byte 0x0
-; IASM-NEXT: 	.byte 0x21
-; IASM-NEXT: 	.byte 0x10
-; IASM-NEXT: 	.byte 0x80
-; IASM-NEXT: 	.byte 0x0
-; IASM-NEXT: 	.byte 0x8
-; IASM-NEXT: 	.byte 0x0
-; IASM-NEXT: 	.byte 0xe0
-; IASM-NEXT: 	.byte 0x3
+; IASM-NEXT:	.byte 0x7
+; IASM-NEXT:	.byte 0x20
+; IASM-NEXT:	.byte 0xa4
+; IASM-NEXT:	.byte 0x0
+; IASM-NEXT:	.byte 0x21
+; IASM-NEXT:	.byte 0x10
+; IASM-NEXT:	.byte 0x80
+; IASM-NEXT:	.byte 0x0
+; IASM-NEXT:	.byte 0x8
+; IASM-NEXT:	.byte 0x0
+; IASM-NEXT:	.byte 0xe0
+; IASM-NEXT:	.byte 0x3
+; IASM-NEXT:	.byte 0x0
+; IASM-NEXT:	.byte 0x0
+; IASM-NEXT:	.byte 0x0
+; IASM-NEXT:	.byte 0x0