third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp - Issue 2478113002: Fix UAF in closures posted from InProcessWorkerObjectProxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp

Issue 2478113002: Fix UAF in closures posted from InProcessWorkerObjectProxy (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h ('k') | third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp

diff --git a/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp b/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp

index 63a575e51722765e7ef34032507dbb8fca4e423e..62e12b774d113ee14d3bff78f4bc51c1b4b40628 100644

--- a/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp

+++ b/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp

@@ -87,11 +87,14 @@ InProcessWorkerMessagingProxy::InProcessWorkerMessagingProxy(

InProcessWorkerBase* workerObject,

WorkerClients* workerClients)

: ThreadedMessagingProxyBase(executionContext),

- m_workerObjectProxy(InProcessWorkerObjectProxy::create(this)),

m_workerObject(workerObject),

m_workerClients(workerClients),

m_unconfirmedMessageCount(0),

- m_workerGlobalScopeMayHavePendingActivity(false) {}

+ m_workerGlobalScopeMayHavePendingActivity(false),

+ m_weakPtrFactory(this) {

+ m_workerObjectProxy =

+ InProcessWorkerObjectProxy::create(m_weakPtrFactory.createWeakPtr());

InProcessWorkerMessagingProxy::~InProcessWorkerMessagingProxy() {

DCHECK(!m_workerObject);