Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Unified Diff: components/autofill/core/browser/autofill_external_delegate.cc

Issue 2478043002: HTTP Bad: Add warning message to autofill dropdown for http sites (Closed)
Patch Set: add test to AutofillManagerTest Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_external_delegate.cc
diff --git a/components/autofill/core/browser/autofill_external_delegate.cc b/components/autofill/core/browser/autofill_external_delegate.cc
index 6b04aa5b5733fa0e876d9bb7fe52e030075ccd62..1f9a370a61316d27d723784583f419c17abe8c90 100644
--- a/components/autofill/core/browser/autofill_external_delegate.cc
+++ b/components/autofill/core/browser/autofill_external_delegate.cc
@@ -301,10 +301,11 @@ void AutofillExternalDelegate::FillAutofillFormData(int unique_id,
void AutofillExternalDelegate::ApplyAutofillWarnings(
std::vector<Suggestion>* suggestions) {
- if (suggestions->size() > 1 &&
- (*suggestions)[0].frontend_id == POPUP_ITEM_ID_WARNING_MESSAGE) {
- // If we received a warning instead of suggestions from Autofill but regular
- // suggestions from autocomplete, don't show the Autofill warning.
+ while (suggestions->size() > 1 &&
+ suggestions->front().frontend_id == POPUP_ITEM_ID_WARNING_MESSAGE &&
+ suggestions->back().frontend_id != POPUP_ITEM_ID_WARNING_MESSAGE) {
+ // If we received warnings instead of suggestions from Autofill but regular
+ // suggestions from autocomplete, don't show the Autofill warnings.
suggestions->erase(suggestions->begin());
}
}

Powered by Google App Engine
This is Rietveld 408576698