HTTP Bad: Add warning message to autofill dropdown for http sites

components/autofill/core/browser/autofill_external_delegate.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXTERNAL_DELEGATE_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXTERNAL_DELEGATE_H_
 
 #include <vector>
 
 #include "base/compiler_specific.h"
@@ skipping 82 matching lines @@
 
   // Called when a credit card is scanned using device camera.
   void OnCreditCardScanned(const CreditCard& card);
 
   // Fills the form with the Autofill data corresponding to |unique_id|.
   // If |is_preview| is true then this is just a preview to show the user what
   // would be selected and if |is_preview| is false then the user has selected
   // this data.
   void FillAutofillFormData(int unique_id, bool is_preview);
 
-  // Handle applying any Autofill warnings to the Autofill popup.
-  void ApplyAutofillWarnings(std::vector<Suggestion>* suggestions);
+  // Will remove Autofill warnings from |suggestions| if there are also
+  // autocomplete entries in the vector. Note: at this point, it is assumed that
+  // if there are Autofill warnings, they will be at the head of the vector and
+  // any entry that is not an Autofill warning is considered an Autocomplete
+  // entry.
+  void PossiblyRemoveAutofillWarnings(std::vector<Suggestion>* suggestions);
 
   // Handle applying any Autofill option listings to the Autofill popup.
   // This function should only get called when there is at least one
   // multi-field suggestion in the list of suggestions.
   void ApplyAutofillOptions(std::vector<Suggestion>* suggestions);
 
   // Insert the data list values at the start of the given list, including
   // any required separators. Will also go through |suggestions| and remove
   // duplicate autocomplete (not Autofill) suggestions, keeping their datalist
   // version.
   void InsertDataListValues(std::vector<Suggestion>* suggestions);
 
+  // Returns true if the suggestion entry is an Autofill warning message.
+  // Warning message should display on top of suggestion list.
+  bool IsAutofillWarningEntry(int frontend_id);

[Mathieu, 2016/11/08 17:26:17]

this can be in the anonymous namespace of the cc file.

[lshang, 2016/11/08 23:39:06]

Done.

+
   AutofillManager* manager_;  // weak.
 
   // Provides driver-level context to the shared code of the component. Must
   // outlive this object.
   AutofillDriver* driver_;  // weak
 
   // The ID of the last request sent for form field Autofill.  Used to ignore
   // out of date responses.
   int query_id_;
 
@@ skipping 26 matching lines @@
   std::vector<base::string16> data_list_labels_;
 
   base::WeakPtrFactory<AutofillExternalDelegate> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillExternalDelegate);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXTERNAL_DELEGATE_H_