Remove assumption that null containerForRepaint assumes RenderView

Remove assumption that null containerForRepaint assumes RenderView

Previously, when containerForRepaint was null, this would mean that
either the renderer wasn't rooted, or its container for repaint was
a non-composited RenderView. This patch changes containerForRepaint
to only return null when the renderer isn't rooted, and to actually
return the RenderView when that's the container. This allows
many of the callsites to be simplified to not check for null, and
removes the need of callers to understand the general assumption
that null means RenderView.

BUG=363699
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172531

[ojan, 2014-04-23 02:07:30]

lgtm

<3

Please address comments before committing.

https://codereview.chromium.org/247803003/diff/1/Source/core/frame/FrameView.cpp
File Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/247803003/diff/1/Source/core/frame/FrameView....
Source/core/frame/FrameView.cpp:709: // FIXME: It's a bug that compositing state
isn't always up to date when this is called.
Can you add to this comment a test that fails when this disabler is removed? Or,
even better, file a bug and list all the tests that fail. That way, when someone
tries to fix this in a few weeks, they'll know if they are correctly reproducing
the issue.

It's happened a bunch of times that someone removes the disabler and no tests
fail. Then that person needs to waste a bunch of time trying to figure out
what's going on.

https://codereview.chromium.org/247803003/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderObject.cpp (right):

https://codereview.chromium.org/247803003/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderObject.cpp:1336: RenderView* v = view();
Mind renaming this to renderView while you're in this code?

https://codereview.chromium.org/247803003/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderObject.cpp:1370: if (!repaintContainer)
Can we ASSERT(!isRooted()) here?

https://codereview.chromium.org/247803003/diff/1/Source/core/rendering/compos...
File Source/core/rendering/compositing/RenderLayerCompositor.cpp (right):

https://codereview.chromium.org/247803003/diff/1/Source/core/rendering/compos...
Source/core/rendering/compositing/RenderLayerCompositor.cpp:796: 
Nit: I'd remove the newlines before/after the assert.

[leviw_travelin_and_unemployed, 2014-04-24 00:48:08]

The CQ bit was checked by leviw@chromium.org

[commit-bot: I haz the power, 2014-04-24 00:48:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/leviw@chromium.org/247803003/20001

[leviw_travelin_and_unemployed, 2014-04-24 00:48:37]

Done done done! CQ powers activate!

[commit-bot: I haz the power, 2014-04-24 01:22:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 01:22:15]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_rel

[leviw_travelin_and_unemployed, 2014-04-24 18:12:22]

The CQ bit was checked by leviw@chromium.org

[commit-bot: I haz the power, 2014-04-24 18:12:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/leviw@chromium.org/247803003/20001

[commit-bot: I haz the power, 2014-04-24 18:43:28]

Change committed as 172531