Issue 2478013004: [Merge M55] [Autofill] Credit card signin promo: do not require a local suggestion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2478013004: [Merge M55] [Autofill] Credit card signin promo: do not require a local suggestion (Closed)

Created:
4 years, 1 month ago by Mathieu

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Merge M55] [Autofill] Credit card signin promo: do not require a local suggestion Previously was requiring a local credit card suggestions before showing the promo. Now it can show when there are no credit card suggestions. BUG=626442 TEST=AutofillManager,AutofillExternalDelegate Committed: https://chromium.googlesource.com/chromium/src/+/35c44c94604f879ae637fc942274cf528db57ed6

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+104 lines, -25 lines)			Patch
M	components/autofill/core/browser/autofill_external_delegate.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/autofill/core/browser/autofill_external_delegate.cc	View	5 chunks	+26 lines, -19 lines	0 comments	Download
M	components/autofill/core/browser/autofill_external_delegate_unittest.cc	View	2 chunks	+36 lines, -2 lines	0 comments	Download
M	components/autofill/core/browser/autofill_manager.cc	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	components/autofill/core/browser/autofill_manager_unittest.cc	View	2 chunks	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mathieu

4 years, 1 month ago (2016-11-04 18:20:13 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
35c44c94604f879ae637fc942274cf528db57ed6.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages