third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp - Issue 2478013002: bluetooth: Invalidate services upon disconnection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp

Issue 2478013002: bluetooth: Invalidate services upon disconnection (Closed)

Patch Set: Address scheib's comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp

index 7a33a680bbad9d60282e39caf24f9d47843d3a0e..ca5b518442a24a7d2334afc5d9ee05d108a25240 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp

@@ -100,13 +100,10 @@ ScriptPromise BluetoothRemoteGATTServer::connect(ScriptState* scriptState) {

void BluetoothRemoteGATTServer::disconnect(ScriptState* scriptState) {

if (!m_connected)

return;

- m_connected = false;

- ClearActiveAlgorithms();

+ device()->cleanupDisconnectedDeviceAndFireEvent();

WebBluetooth* webbluetooth =

BluetoothSupplement::fromScriptState(scriptState);

webbluetooth->disconnect(device()->id());

- device()->dispatchEvent(

- Event::createBubble(EventTypeNames::gattserverdisconnected));

}

// Class that allows us to resolve the promise with a single service or