Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2477983003: Improve a11y state for ToggleButton. (Closed)

Created:
4 years, 1 month ago by Evan Stade
Modified:
4 years, 1 month ago
Reviewers:
varkha, dmazzoni, sadrul
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, oshima+watch_chromium.org, sadrul, tfarina, mohsen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve a11y state for ToggleButton. Also add a description for the wifi toggle button instance. BUG=652677 Committed: https://crrev.com/48df76a8d587632d3c83119b6be669c2a222b4a4 Cr-Commit-Position: refs/heads/master@{#429992}

Patch Set 1 #

Total comments: 1

Patch Set 2 : use switch role, rebase on top of dmazzoni changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M ash/common/system/chromeos/network/network_list_md.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/button/toggle_button.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/button/toggle_button.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Evan Stade
4 years, 1 month ago (2016-11-04 02:47:30 UTC) #3
varkha
lgtm, thanks! +mohsen@ - please take a look, you may need something similar for the ...
4 years, 1 month ago (2016-11-04 06:27:56 UTC) #7
sadrul
+dmazzoni@ for a11y owner review. lgtm
4 years, 1 month ago (2016-11-04 15:05:52 UTC) #9
Evan Stade
https://codereview.chromium.org/2477983003/diff/1/ash/common/system/chromeos/network/network_list_md.cc File ash/common/system/chromeos/network/network_list_md.cc (right): https://codereview.chromium.org/2477983003/diff/1/ash/common/system/chromeos/network/network_list_md.cc#newcode167 ash/common/system/chromeos/network/network_list_md.cc:167: l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_ENABLE_WIFI)); forgot to mention -- this could also be ...
4 years, 1 month ago (2016-11-04 15:16:37 UTC) #10
dmazzoni
lgtm +1 for the tool tip idea if that makes sense
4 years, 1 month ago (2016-11-04 16:46:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477983003/20001
4 years, 1 month ago (2016-11-04 18:45:52 UTC) #14
Evan Stade
On 2016/11/04 16:46:21, dmazzoni wrote: > lgtm > > +1 for the tool tip idea ...
4 years, 1 month ago (2016-11-04 18:52:42 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 20:15:25 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 20:19:15 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/48df76a8d587632d3c83119b6be669c2a222b4a4
Cr-Commit-Position: refs/heads/master@{#429992}

Powered by Google App Engine
This is Rietveld 408576698