Improve a11y state for ToggleButton.

Improve a11y state for ToggleButton.

Also add a description for the wifi toggle button instance.

BUG=652677
Committed: https://crrev.com/48df76a8d587632d3c83119b6be669c2a222b4a4
Cr-Commit-Position: refs/heads/master@{#429992}

[Evan Stade, 2016-11-04 02:47:05]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2016-11-04 02:47:30]

estade@chromium.org changed reviewers:
+ sadrul@chromium.org, varkha@chromium.org

[commit-bot: I haz the power, 2016-11-04 02:47:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 05:32:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 05:32:49]

Dry run: This issue passed the CQ dry run.

[varkha, 2016-11-04 06:27:56]

lgtm, thanks!
+mohsen@ - please take a look, you may need something similar for the other
toggle on the new cellular header row.

[sadrul, 2016-11-04 15:05:52]

sadrul@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[sadrul, 2016-11-04 15:05:52]

+dmazzoni@ for a11y owner review.

lgtm

[Evan Stade, 2016-11-04 15:16:37]

https://codereview.chromium.org/2477983003/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/network/network_list_md.cc (right):

https://codereview.chromium.org/2477983003/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/network/network_list_md.cc:167:
l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_ENABLE_WIFI));
forgot to mention -- this could also be set as a tooltip (which would give us
the a11y description for "free"). Do we want a tooltip?

[dmazzoni, 2016-11-04 16:46:21]

lgtm

+1 for the tool tip idea if that makes sense

[Evan Stade, 2016-11-04 18:45:15]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-11-04 18:45:15]

The patchset sent to the CQ was uploaded after l-g-t-m from varkha@chromium.org,
sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2477983003/#ps20001
(title: "use switch role, rebase on top of dmazzoni changes")

[commit-bot: I haz the power, 2016-11-04 18:45:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-11-04 18:52:42]

On 2016/11/04 16:46:21, dmazzoni wrote:
> lgtm
> 
> +1 for the tool tip idea if that makes sense

I'll bring up the tooltip issue with other but it seems to me and Terry that
it's redundant with the text next to the toggle.

[commit-bot: I haz the power, 2016-11-04 20:15:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-04 20:19:13]

Description was changed from

==========
Improve a11y state for ToggleButton.

Also add a description for the wifi toggle button instance.

BUG=652677
==========

to

==========
Improve a11y state for ToggleButton.

Also add a description for the wifi toggle button instance.

BUG=652677

Committed: https://crrev.com/48df76a8d587632d3c83119b6be669c2a222b4a4
Cr-Commit-Position: refs/heads/master@{#429992}
==========

[commit-bot: I haz the power, 2016-11-04 20:19:15]

Patchset 2 (id:??) landed as
https://crrev.com/48df76a8d587632d3c83119b6be669c2a222b4a4
Cr-Commit-Position: refs/heads/master@{#429992}