Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2477913002: Add support of optional leader_point in NGLayoutOpportunityIterator (Closed)

Created:
4 years, 1 month ago by Gleb Lanbin
Modified:
4 years, 1 month ago
Reviewers:
ikilpatrick
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support of optional leader_point in NGLayoutOpportunityIterator Leader point together with origin_point creates a temporary exclusion that should be avoided in the layout opportunity iterator. This patch is based on the already reviewed, submitted, reverted patch http://crrev.com/2472583006 with the only difference that it uses WTF::Optional for NGLayoutOpportunityIterator's optional parameters. BUG=635619 Committed: https://crrev.com/ee9219e2ac383a0f44fb7b40dac2b6d10a491935 Cr-Commit-Position: refs/heads/master@{#429775}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -19 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc View 2 chunks +10 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc View 2 chunks +49 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units.h View 2 chunks +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Gleb Lanbin
4 years, 1 month ago (2016-11-03 21:15:34 UTC) #3
ikilpatrick
lgtm
4 years, 1 month ago (2016-11-03 21:19:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477913002/1
4 years, 1 month ago (2016-11-04 02:55:19 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 03:01:04 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 03:04:02 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee9219e2ac383a0f44fb7b40dac2b6d10a491935
Cr-Commit-Position: refs/heads/master@{#429775}

Powered by Google App Engine
This is Rietveld 408576698