Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 2477903002: Adjust tests/standalone/io/file_test not to resolve relative to Platform.executable. (Closed)

Created:
4 years, 1 month ago by rmacnak
Modified:
4 years, 1 month ago
Reviewers:
siva
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adjust tests/standalone/io/file_test not to resolve relative to Platform.executable. Fixes #27748 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/93e55dbe6e14b40197a74176388fdcf65a0a059a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -14 lines) Patch
A + tests/standalone/io/empty_file View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/standalone/io/file_test.dart View 9 chunks +10 lines, -15 lines 0 comments Download
A + tests/standalone/io/file_test.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 1 month ago (2016-11-03 21:10:25 UTC) #2
siva
lgtm
4 years, 1 month ago (2016-11-03 22:20:44 UTC) #3
rmacnak
4 years, 1 month ago (2016-11-03 23:18:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
93e55dbe6e14b40197a74176388fdcf65a0a059a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698