Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2477893002: Clear last MouseMove root view in RWHIER if that view gets destroyed (Closed)

Created:
4 years, 1 month ago by kenrb
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Clear last MouseMove root view in RWHIER if that view gets destroyed Cluster-fuzz has reported some difficult-to-reproduce crashes in the MouseEnter/Leave generation code in RenderWidgetHostInputEventRouter, and there are some very sparse crash reports appearing for that also. These might be caused by race conditions from RenderWidgetHostView tree modifications that get slightly out of sync from the Surface state that is used for hit testing (Surfaces aren't invalidated until RWHVs are deleted, which for some RWHVs is not immediate upon them having Destroy() called). This CL speculatively tries to address the crashes by having SendMouseEnterOrLeaveEvents abort when it discovers the RWHV tree out of sync, and also clearing last_mouse_move_root_view_ when that gets destroyed. BUG=647821, 652209 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2396083002 Cr-Commit-Position: refs/heads/master@{#424533} (cherry picked from commit 83e4f9ac895d5b42a4b114f3ef964676a40476ff) Committed: https://chromium.googlesource.com/chromium/src/+/68f883645ff0c2f46fa75128af0642e87e7095bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -8 lines) Patch
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_input_event_router.cc View 2 chunks +17 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kenrb
4 years, 1 month ago (2016-11-03 20:59:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
68f883645ff0c2f46fa75128af0642e87e7095bd.

Powered by Google App Engine
This is Rietveld 408576698