Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2477883002: [Web Payments] Mojom namespace blink -> payments (Closed)

Created:
4 years, 1 month ago by Kevin Bailey
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, blink-reviews, chromium-reviews, darin (slow to review), haraken, qsr+mojo_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Web Payments] Mojom namespace blink -> payments When we migrated payment_request.mojom from Blink to components/ we left the namespace in place to minimize changes and facilitate the move. This CL simply changes the namespace that the payment request stuff resides in. Lots of files changed, little depth. BUG=659644 Committed: https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2 Committed: https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b Cr-Original-Commit-Position: refs/heads/master@{#430990} Cr-Commit-Position: refs/heads/master@{#431320}

Patch Set 1 #

Patch Set 2 : Fix namespace in tests #

Patch Set 3 : Trying clobber landmine #

Patch Set 4 : Rebase #

Patch Set 5 : Fix WebKit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -206 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/payments/android/payments_jni_registrar.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M components/payments/payment_details_validation.h View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/payment_details_validation.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M components/payments/payment_request.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/payments_validators.h View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/payments_validators.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/payments_validators_test.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/AbortTest.cpp View 1 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/CompleteTest.cpp View 1 6 chunks +18 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/OnPaymentResponseTest.cpp View 1 29 chunks +100 lines, -94 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentAddress.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentAddress.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentAddressTest.cpp View 1 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.h View 3 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 10 chunks +34 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp View 1 6 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponse.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponse.cpp View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp View 1 2 3 5 chunks +11 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentTestHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentsValidators.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentsValidatorsTest.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 32 (22 generated)
Kevin Bailey
Hi Rouslan, Here's the namespace change that you mentioned in cl/2373103002. Despite touching lots of ...
4 years, 1 month ago (2016-11-03 20:51:44 UTC) #3
please use gerrit instead
lgtm
4 years, 1 month ago (2016-11-03 21:24:59 UTC) #4
Mike West
mojom LGTM
4 years, 1 month ago (2016-11-07 09:53:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477883002/80001
4 years, 1 month ago (2016-11-09 18:40:18 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-09 18:45:44 UTC) #22
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2 Cr-Commit-Position: refs/heads/master@{#430990}
4 years, 1 month ago (2016-11-09 19:17:02 UTC) #24
Dirk Pranke
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2489943003/ by dpranke@chromium.org. ...
4 years, 1 month ago (2016-11-09 19:47:31 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477883002/80001
4 years, 1 month ago (2016-11-10 17:23:11 UTC) #28
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-10 19:46:10 UTC) #30
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 20:10:40 UTC) #32
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b
Cr-Commit-Position: refs/heads/master@{#431320}

Powered by Google App Engine
This is Rietveld 408576698