Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1209)

Issue 2477873002: Ensure the substitution map in the CloneVisitor is mutable. (Closed)

Created:
4 years, 1 month ago by asgerf
Modified:
4 years, 1 month ago
CC:
dart-kernel+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ensure the substitution map in the CloneVisitor is mutable. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/kernel/commit/da7f856b371573f1887d1402b5decf75ae5505ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M lib/clone.dart View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
4 years, 1 month ago (2016-11-03 20:38:37 UTC) #2
Kevin Millikin (Google)
LGTM.
4 years, 1 month ago (2016-11-04 08:25:38 UTC) #3
asgerf
4 years, 1 month ago (2016-11-04 09:44:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
da7f856b371573f1887d1402b5decf75ae5505ff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698