Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2477673004: Revert of Add virtual tests for XHR with mojo-loading (Closed)

Created:
4 years, 1 month ago by Mike West
Modified:
4 years, 1 month ago
Reviewers:
yhirano, tzik
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, blink-reviews, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add virtual tests for XHR with mojo-loading (patchset #3 id:40001 of https://codereview.chromium.org/2463753002/ ) Reason for revert: This patch revealed some ASAN and MSAN failures: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise%20ASAN/builds/882 and https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise%20MSAN/builds/863. Reverting for now, please take a look. Original issue's description: > Add virtual tests for XHR with mojo-loading > > This CL adds virtual XHR tests with mojo-loading as > virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of > failures. We add them to TestExpectations and will fix them later. > > BUG=659917 > > Committed: https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a > Cr-Commit-Position: refs/heads/master@{#429808} TBR=tzik@chromium.org,yhirano@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=659917 Committed: https://crrev.com/e534e155454891adab9362f55373644e17f76ea2 Cr-Commit-Position: refs/heads/master@{#429856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -68 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -66 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/virtual/mojo-loading/http/tests/xmlhttprequest/README.txt View 1 chunk +0 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/virtual/mojo-loading/http/tests/xmlhttprequest/web-apps/README.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mike West
Created Revert of Add virtual tests for XHR with mojo-loading
4 years, 1 month ago (2016-11-04 11:17:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477673004/1
4 years, 1 month ago (2016-11-04 11:17:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 11:18:36 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 11:20:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e534e155454891adab9362f55373644e17f76ea2
Cr-Commit-Position: refs/heads/master@{#429856}

Powered by Google App Engine
This is Rietveld 408576698