DBC: Handle constants correctly in the optimizing backend

runtime/vm/intermediate_language_dbc.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_DBC.
 #if defined(TARGET_ARCH_DBC)
 
 #include "vm/intermediate_language.h"
 
 #include "vm/cpu.h"
@@ skipping 320 matching lines @@
 EMIT_NATIVE_CODE(LoadClassId, 1, Location::RequiresRegister()) {
   if (compiler->is_optimizing()) {
     __ LoadClassId(locs()->out(0).reg(), locs()->in(0).reg());
   } else {
     __ LoadClassIdTOS();
   }
 }
 
 
 EMIT_NATIVE_CODE(Constant, 0, Location::RequiresRegister()) {
-  if (compiler->is_optimizing()) {
+  if (compiler->is_optimizing() && locs()->out(0).IsRegister()) {

[Vyacheslav Egorov (Google), 2016/11/03 11:11:50]

We will end up Pushing the constant on the stack here.

Maybe you wanted to do:

if (... is_optimizing()) {
  if (... IsRegister()) {
  }
} else ...

Instead?

[Florian Schneider, 2016/11/03 11:22:59]

Done. Yes, of course. I simplfified the code incorrectly somehow.

     __ LoadConstant(locs()->out(0).reg(), value());
   } else {
     __ PushConstant(value());
   }
 }
 
 
 EMIT_NATIVE_CODE(UnboxedConstant, 0, Location::RequiresRegister()) {
   // The register allocator drops constant definitions that have no uses.
   if (locs()->out(0).IsInvalid()) {
@@ skipping 1612 matching lines @@
   __ IfULe(length, index);
   compiler->EmitDeopt(deopt_id(),
                       ICData::kDeoptCheckArrayBound,
                       (generalized_ ? ICData::kGeneralized : 0) |
                       (licm_hoisted_ ? ICData::kHoisted : 0));
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_DBC