[Mac] Add a feature flag to disable Javascript execution in Applescript

[Mac] Add a feature flag to disable Javascript execution in Applescript

BUG=661810
Committed: https://crrev.com/7e175f3dc08de15c7de87c09a70b1e98551e9fcd
Cr-Commit-Position: refs/heads/master@{#430030}

[spqchan, 2016-11-03 18:57:56]

Description was changed from

==========
[Mac] Added a finch flag to disable Javascript execution in Applescript

BUG=661810
==========

to

==========
[Mac] Add a feature flag to disable Javascript execution in Applescript

BUG=661810
==========

[spqchan, 2016-11-03 18:58:59]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 18:59:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 22:58:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 22:58:13]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[spqchan, 2016-11-03 22:59:55]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 23:01:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 02:22:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 02:22:42]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[spqchan, 2016-11-04 04:44:05]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 04:44:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 05:47:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 05:48:00]

Dry run: This issue passed the CQ dry run.

[spqchan, 2016-11-04 06:25:32]

spqchan@chromium.org changed reviewers:
+ rsesek@chromium.org

[spqchan, 2016-11-04 06:25:33]

PTAL

[Robert Sesek, 2016-11-04 16:37:16]

I found one more location we need to do this: -[BookmarkItemAppleScript
setURL:].

https://codereview.chromium.org/2477633003/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2477633003/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:12191: +          Executing Javascript
through Applescript is no longer supported.
nit: AppleScript

https://codereview.chromium.org/2477633003/diff/1/chrome/common/chrome_featur...
File chrome/common/chrome_features.h (right):

https://codereview.chromium.org/2477633003/diff/1/chrome/common/chrome_featur...
chrome/common/chrome_features.h:19: extern const base::Feature
kApplescriptExecuteJavascript;
nit: AppleScript

[spqchan, 2016-11-04 19:58:44]

PTAL

https://codereview.chromium.org/2477633003/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2477633003/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:12191: +          Executing Javascript
through Applescript is no longer supported.
On 2016/11/04 16:37:16, Robert Sesek wrote:
> nit: AppleScript

Done.

https://codereview.chromium.org/2477633003/diff/1/chrome/common/chrome_featur...
File chrome/common/chrome_features.h (right):

https://codereview.chromium.org/2477633003/diff/1/chrome/common/chrome_featur...
chrome/common/chrome_features.h:19: extern const base::Feature
kApplescriptExecuteJavascript;
On 2016/11/04 16:37:16, Robert Sesek wrote:
> nit: AppleScript

Done.

[spqchan, 2016-11-04 19:58:53]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 19:59:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Robert Sesek, 2016-11-04 20:10:41]

LGTM.

It'd be cool to unittest the feature-disabled case, but I don't know how to test
with FeatureList.

[commit-bot: I haz the power, 2016-11-04 21:11:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 21:11:27]

Dry run: This issue passed the CQ dry run.

[spqchan, 2016-11-04 22:00:49]

On 2016/11/04 20:10:41, Robert Sesek wrote:
> LGTM.
> 
> It'd be cool to unittest the feature-disabled case, but I don't know how to
test
> with FeatureList.

Looked around and no dice =/

[spqchan, 2016-11-04 22:00:55]

The CQ bit was checked by spqchan@chromium.org

[Robert Sesek, 2016-11-04 22:02:32]

On 2016/11/04 22:00:49, spqchan wrote:
> On 2016/11/04 20:10:41, Robert Sesek wrote:
> > LGTM.
> > 
> > It'd be cool to unittest the feature-disabled case, but I don't know how to
> test
> > with FeatureList.
> 
> Looked around and no dice =/

Thanks for looking. Maybe file a follow-up bug to test after we drop the
feature-based check?

[commit-bot: I haz the power, 2016-11-04 22:03:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[spqchan, 2016-11-04 22:05:58]

On 2016/11/04 22:03:10, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Sure thing: crbug.com/662548

Worst case, maybe we can have some AppleScript scripts for testing.

[commit-bot: I haz the power, 2016-11-04 22:09:58]

Description was changed from

==========
[Mac] Add a feature flag to disable Javascript execution in Applescript

BUG=661810
==========

to

==========
[Mac] Add a feature flag to disable Javascript execution in Applescript

BUG=661810
==========

[commit-bot: I haz the power, 2016-11-04 22:09:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-04 22:13:05]

Description was changed from

==========
[Mac] Add a feature flag to disable Javascript execution in Applescript

BUG=661810
==========

to

==========
[Mac] Add a feature flag to disable Javascript execution in Applescript

BUG=661810

Committed: https://crrev.com/7e175f3dc08de15c7de87c09a70b1e98551e9fcd
Cr-Commit-Position: refs/heads/master@{#430030}
==========

[commit-bot: I haz the power, 2016-11-04 22:13:10]

Patchset 3 (id:??) landed as
https://crrev.com/7e175f3dc08de15c7de87c09a70b1e98551e9fcd
Cr-Commit-Position: refs/heads/master@{#430030}