[Presentation API] (3rd) (1-UA) Split PresentationServiceDelegateImpl(PSDImpl)

content/public/browser/presentation_service_delegate.h

Index: content/public/browser/presentation_service_delegate.h
diff --git a/content/public/browser/presentation_service_delegate.h b/content/public/browser/presentation_service_delegate.h
index 506b33da58c8d2778187cd640a302233592f6db6..3863ce56ef9ce3e925db24e31fd2788299f4c07e 100644
--- a/content/public/browser/presentation_service_delegate.h
+++ b/content/public/browser/presentation_service_delegate.h
@@ -56,9 +56,9 @@ using ReceiverConnectionAvailableCallback =
     base::Callback<void(const content::PresentationSessionInfo&,
                         PresentationConnectionPtr&&)>;
 
-// An interface implemented by embedders to handle presentation API calls
-// forwarded from PresentationServiceImpl.
-class CONTENT_EXPORT PresentationServiceDelegate {
+// Base class for ControllerPresentationServiceDelegate and
+// ReceiverPresentationServiceDelegate.
+class PresentationServiceDelegateBase {
  public:
   // Observer interface to listen for changes to PresentationServiceDelegate.
   class CONTENT_EXPORT Observer {

[mark a. foltz, 2016/11/15 23:41:47]

Maybe this should become PresentatonServiceDelegateObserver since it's not
specific to this class anymore?  I don't feel strongly but usually "FooObserver"
is an observer for "Foo".

Bin, Derek, WDYT?

[zhaobin, 2016/11/16 18:02:42]

Done.

@@ -70,10 +70,6 @@ class CONTENT_EXPORT PresentationServiceDelegate {
     virtual ~Observer() {}
   };
 
-  using SendMessageCallback = base::Callback<void(bool)>;
-
-  virtual ~PresentationServiceDelegate() {}
-
   // Registers an observer associated with frame with |render_process_id|
   // and |render_frame_id| with this class to listen for updates.
   // This class does not own the observer.
@@ -88,6 +84,22 @@ class CONTENT_EXPORT PresentationServiceDelegate {
   // The observer will no longer receive updates.
   virtual void RemoveObserver(int render_process_id, int render_frame_id) = 0;
 
+  // Resets the presentation state for the frame given by |render_process_id|
+  // and |render_frame_id|.
+  // This unregisters all listeners associated with the given frame, and clears

[mark a. foltz, 2016/11/15 23:41:47]

screen availability listeners

[zhaobin, 2016/11/16 18:02:42]

Done.

+  // the default presentation URL and ID set for the frame.

[mark a. foltz, 2016/11/15 23:41:47]

the default presentation URL for the frame.

[zhaobin, 2016/11/16 18:02:42]

Done.

+  virtual void Reset(int render_process_id, int render_frame_id) = 0;
+};
+
+// An interface implemented by embedders to handle presentation API calls

[mark a. foltz, 2016/11/15 23:41:47]

nit: Presentation

[zhaobin, 2016/11/16 18:02:42]

Done.

+// forwarded from PresentationServiceImpl.
+class CONTENT_EXPORT ControllerPresentationServiceDelegate
+    : public PresentationServiceDelegateBase {
+ public:
+  using SendMessageCallback = base::Callback<void(bool)>;
+
+  virtual ~ControllerPresentationServiceDelegate() {}
+
   // Registers |listener| to continuously listen for
   // availability updates for a presentation URL, originated from the frame
   // given by |render_process_id| and |render_frame_id|.
@@ -108,14 +120,6 @@ class CONTENT_EXPORT PresentationServiceDelegate {
       int render_frame_id,
       PresentationScreenAvailabilityListener* listener) = 0;
 
-  // Resets the presentation state for the frame given by |render_process_id|
-  // and |render_frame_id|.
-  // This unregisters all listeners associated with the given frame, and clears
-  // the default presentation URL and ID set for the frame.
-  virtual void Reset(
-      int render_process_id,
-      int render_frame_id) = 0;
-
   // Sets the default presentation URLs for frame given by |render_process_id|
   // and |render_frame_id|. When the default presentation is started on this
   // frame, |callback| will be invoked with the corresponding
@@ -209,6 +213,31 @@ class CONTENT_EXPORT PresentationServiceDelegate {
       int render_frame_id,
       const PresentationSessionInfo& connection,
       const PresentationConnectionStateChangedCallback& state_changed_cb) = 0;
+
+  // Connect |connection| owned by the controlling frame to the offscreen
+  // presentation represented by |session|.
+  // |render_process_id|, |render_frame_id|: ID of originating frame.
+  // |connection|: Pointer to controller's presentation connection,
+  // ownership passed from controlling frame to the offscreen presentation.
+  virtual void ConnectToOffscreenPresentation(
+      int render_process_id,
+      int render_frame_id,
+      const PresentationSessionInfo& session,
+      PresentationConnectionPtr connection) = 0;
+};
+
+// An interface implemented by embedders to handle
+// PresentationService calls from a presentation receiver.
+class CONTENT_EXPORT ReceiverPresentationServiceDelegate
+    : public PresentationServiceDelegateBase {
+ public:
+  // Registers a callback from the embedder when an offscreeen presentation has
+  // been successfully started.
+  // |receiver_available_callback|: Invoked when successfully starting a
+  // offscreen presentation session.
+  virtual void RegisterReceiverConnectionAvailableCallback(
+      const content::ReceiverConnectionAvailableCallback&
+          receiver_available_callback) = 0;
 };
 
 }  // namespace content