[Presentation API] (3rd) (1-UA) Split PresentationServiceDelegateImpl(PSDImpl)

third_party/WebKit/public/platform/modules/presentation/presentation.mojom

Index: third_party/WebKit/public/platform/modules/presentation/presentation.mojom
diff --git a/third_party/WebKit/public/platform/modules/presentation/presentation.mojom b/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
index 847ed6cbc1b607903bca79599d44d55fd373a0ea..3a124719769478f1d6cfa4b8669b527eeb6d277f 100644
--- a/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
+++ b/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
@@ -53,10 +53,23 @@ struct ConnectionMessage {
   array<uint8>? data;
 };
 
+interface PresentationConnection {
+   // TODO(zhaobin): migrate SendConnectionMessage from PresentationService =>
+   // PresentationConnection.Send(). http://crbug.com/658474
+
+   // Called when a message is sent by the target connection.
+   OnMessage(ConnectionMessage message) => (bool success);
+
+   // Called when target connection notifies connection state change.
+   DidChangeState(PresentationConnectionState state);
+};
+
 interface PresentationService {
   // Sets the PresentationServiceClient.
   SetClient(PresentationServiceClient client);
 
+  ///////////// Functions here are for the controller part of the API. /////////
+
   // Called when the frame sets or changes the default presentation URLs.
   // When the default presentation is started on this frame,
   // PresentationServiceClient::OnDefaultSessionStarted will be invoked.
@@ -91,6 +104,15 @@ interface PresentationService {
   JoinSession(array<url.mojom.Url> presentation_urls, string? presentation_id)
       => (PresentationSessionInfo? sessionInfo, PresentationError? error);
 
+  // Called in StartSession's callback function for offscreen presentation only.
+  // It passes in controlling frame's PresentationConnection and
+  // PresentationConnectionRequest to PresentationService.
+  SetPresentationConnection(PresentationSessionInfo sessionInfo,
+                            PresentationConnection controller_conn_ptr,

[dcheng, 2017/01/10 06:46:59]

Nit: conn => connection here and below. Same below as well.

[zhaobin, 2017/01/10 21:49:54]

Done.

+                            PresentationConnection& receiver_conn_request);
+
+  //////////////////////////////////////////////////////////////////////////////
+
   // Called when send() is called by the frame. The true in the
   // result callback notifies that the service is ready for next message.
   // The false in the result callback notifies the renderer to stop sending
@@ -113,6 +135,9 @@ interface PresentationService {
 };
 
 interface PresentationServiceClient {
+
+  ////////////Functions here are called only on the controlling page.///////////
+
   // Called when the client tries to listen for screen availability changes for
   // presentation of |url| but it is not supported by the device or underlying
   // platform. This can also be called if the device is currently in a mode
@@ -125,6 +150,11 @@ interface PresentationServiceClient {
   // the current known state. It will then be called to notify of state updates.
   OnScreenAvailabilityUpdated(url.mojom.Url url, bool available);
 
+  // See PresentationService::SetDefaultPresentationURL.
+  OnDefaultSessionStarted(PresentationSessionInfo sessionInfo);
+
+  //////////////////////////////////////////////////////////////////////////////
+
   // Called when the state of PresentationConnection |connection| started on
   // this frame has changed to |newState|.
   OnConnectionStateChanged(PresentationSessionInfo connection,
@@ -140,9 +170,9 @@ interface PresentationServiceClient {
   OnConnectionMessagesReceived(PresentationSessionInfo sessionInfo,
                             array<ConnectionMessage> messages);
 
-  // See PresentationService::SetDefaultPresentationURL.
-  OnDefaultSessionStarted(PresentationSessionInfo sessionInfo);
-
-  // See PresentationService::OnReceiverConnectionAvailable.
-  OnReceiverConnectionAvailable(PresentationSessionInfo sessionInfo);
+  // Called on a presentation receiver when the first presentation connection is

[dcheng, 2017/01/10 06:46:58]

What happens when subsequent connections are available? I'm just trying to
understand the significance of 'first' here.

[zhaobin, 2017/01/10 21:49:54]

Done.

Outdated comments. It is invoked for all presentation connections on controlling
page.

+  // available from the controlling page.
+  OnReceiverConnectionAvailable(PresentationSessionInfo sessionInfo,
+                                PresentationConnection controller_conn_ptr,
+                                PresentationConnection& receiver_conn_request);
 };