[Presentation API] (3rd) (1-UA) Split PresentationServiceDelegateImpl(PSDImpl)

chrome/browser/media/router/presentation_service_delegate_base_impl.h

Index: chrome/browser/media/router/presentation_service_delegate_base_impl.h
diff --git a/chrome/browser/media/router/presentation_service_delegate_base_impl.h b/chrome/browser/media/router/presentation_service_delegate_base_impl.h
new file mode 100644
index 0000000000000000000000000000000000000000..7295a2068459a5df1b00cd202726e1514de98e67
--- /dev/null
+++ b/chrome/browser/media/router/presentation_service_delegate_base_impl.h
@@ -0,0 +1,35 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_MEDIA_ROUTER_PRESENTATION_SERVICE_DELEGATE_BASE_IMPL_H_
+#define CHROME_BROWSER_MEDIA_ROUTER_PRESENTATION_SERVICE_DELEGATE_BASE_IMPL_H_
+
+#include <map>
+
+#include "chrome/browser/media/router/render_frame_host_id.h"
+#include "content/public/browser/presentation_service_delegate.h"
+
+namespace media_router {
+
+class PresentationServiceDelegateBaseImpl

[imcheng, 2016/11/29 00:39:01]

Before addressing the comments here, consider moving the implementation of
AddObserver/RemoveObserver into PresentationServiceDelegate. That way we can
make the relationship between the PSD classes simpler.

PSD is inherited by ControllerPSD and ReceiverPSD (all in content), which is
implemented by ControllerPSDImpl and ReceiverPSDImpl respectively.

[imcheng, 2016/11/29 00:39:01]

nit: add comments, e.g.:

Base class shared by the controller and receiver implementations of
PresentationServiceDelegate.

[imcheng, 2016/11/29 00:39:01]

naming: Suggest just PresentationServiceDelegateBase

[zhaobin, 2016/11/29 23:22:32]

Code removed

[zhaobin, 2016/11/29 23:22:32]

Done.

[zhaobin, 2016/11/29 23:22:33]

Code removed.

+    : virtual public content::PresentationServiceDelegate {

[imcheng, 2016/11/29 00:39:01]

virtual not needed?

[zhaobin, 2016/11/29 23:22:33]

Done.

+ public:
+  PresentationServiceDelegateBaseImpl();
+  virtual ~PresentationServiceDelegateBaseImpl();
+
+  // content::PresentationServiceDelegateBase implementation.
+  void AddObserver(
+      int render_process_id,
+      int render_frame_id,
+      content::PresentationServiceDelegate::Observer* observer) override;
+  void RemoveObserver(int render_process_id, int render_frame_id) override;
+
+ private:
+  std::map<RenderFrameHostId, content::PresentationServiceDelegate::Observer*>
+      observers_;
+};
+
+}  // namespace media_router
+
+#endif  // CHROME_BROWSER_MEDIA_ROUTER_PRESENTATION_SERVICE_DELEGATE_BASE_IMPL_H_