Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: chrome/browser/media/router/offscreen_presentation_manager.h

Issue 2477573002: [Presentation API] (3rd) (1-UA) Split PresentationServiceDelegateImpl(PSDImpl) (Closed)
Patch Set: resolve code review comments from Mark Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/offscreen_presentation_manager.h
diff --git a/chrome/browser/media/router/offscreen_presentation_manager.h b/chrome/browser/media/router/offscreen_presentation_manager.h
index 6bef7f743c37f5180c7f1d8fbba347688ef9d09b..e79b86bf060582159a8bb9ed9c25705be1bf0a16 100644
--- a/chrome/browser/media/router/offscreen_presentation_manager.h
+++ b/chrome/browser/media/router/offscreen_presentation_manager.h
@@ -100,7 +100,7 @@ class OffscreenPresentationManager : public KeyedService {
// exists.
// |controller|: Not owned by this class. Ownership is transferred to the
// presentation receiver via |receiver_callback| passed below.
- void RegisterOffscreenPresentationController(
+ virtual void RegisterOffscreenPresentationController(
const std::string& presentation_id,
const GURL& presentation_url,
const RenderFrameHostId& render_frame_id,
@@ -111,20 +111,20 @@ class OffscreenPresentationManager : public KeyedService {
// controller that matches the provided arguments. It removes presentation
// that matches the arguments if the presentation has no receiver_callback and
// any other pending controller.
- void UnregisterOffscreenPresentationController(
+ virtual void UnregisterOffscreenPresentationController(
const std::string& presentation_id,
const RenderFrameHostId& render_frame_id);
// Registers ReceiverConnectionAvailableCallback to presentation
// with |presentation_id|.
- void OnOffscreenPresentationReceiverCreated(
+ virtual void OnOffscreenPresentationReceiverCreated(
const std::string& presentation_id,
const GURL& presentation_url,
const content::ReceiverConnectionAvailableCallback& receiver_callback);
// Unregisters the ReceiverConnectionAvailableCallback associated with
// |presentation_id|.
- void OnOffscreenPresentationReceiverTerminated(
+ virtual void OnOffscreenPresentationReceiverTerminated(
const std::string& presentation_id);
private:
@@ -184,6 +184,7 @@ class OffscreenPresentationManager : public KeyedService {
private:
friend class OffscreenPresentationManagerFactory;
friend class OffscreenPresentationManagerTest;
+ friend class MockOffscreenPresentationManager;
FRIEND_TEST_ALL_PREFIXES(PresentationServiceDelegateImplTest,
ConnectToOffscreenPresentation);

Powered by Google App Engine
This is Rietveld 408576698