[Presentation API] (3rd) (1-UA) Split PresentationServiceDelegateImpl(PSDImpl)

chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/router/presentation_service_delegate_impl.h"
 
 #include "base/memory/ptr_util.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/media/router/media_source.h"
 #include "chrome/browser/media/router/media_source_helper.h"
 #include "chrome/browser/media/router/mock_media_router.h"
 #include "chrome/browser/media/router/mock_screen_availability_listener.h"
+#include "chrome/browser/media/router/offscreen_presentation_manager.h"
+#include "chrome/browser/media/router/offscreen_presentation_manager_factory.h"
 #include "chrome/browser/media/router/route_request_result.h"
 #include "chrome/browser/media/router/test_helper.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/browser/presentation_screen_availability_listener.h"
 #include "content/public/browser/presentation_session.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/web_contents_tester.h"
 #include "testing/gmock/include/gmock/gmock.h"
 
 using ::testing::_;
 using ::testing::Mock;
 using ::testing::Return;
 using ::testing::SaveArg;
 using ::testing::StrictMock;
 
 namespace {
 
 const char kPresentationUrl1[] = "http://foo.fakeurl.com/";
 const char kPresentationUrl2[] = "http://bar.fakeurl.com/";
 const char kFrameUrl[] = "http://anotherframeurl.fakeurl.com/";
 
 }  // namespace
 
 namespace media_router {
 
 class MockDelegateObserver
-    : public content::PresentationServiceDelegate::Observer {
+    : public content::PresentationServiceDelegateBase::Observer {
  public:
   MOCK_METHOD0(OnDelegateDestroyed, void());
   MOCK_METHOD1(OnDefaultPresentationStarted,
                void(const content::PresentationSessionInfo&));
 };
 
 class MockDefaultPresentationRequestObserver
     : public PresentationServiceDelegateImpl::
           DefaultPresentationRequestObserver {
  public:
@@ skipping 411 matching lines @@
   ASSERT_TRUE(main_frame);
   int render_process_id = main_frame->GetProcess()->GetID();
   int render_frame_id = main_frame->GetRoutingID();
 
   EXPECT_CALL(router_, RegisterMediaSinksObserver(_)).WillOnce(Return(false));
   EXPECT_CALL(listener, OnScreenAvailabilityNotSupported());
   EXPECT_FALSE(delegate_impl_->AddScreenAvailabilityListener(
       render_process_id, render_frame_id, &listener));
 }
 
+TEST_F(PresentationServiceDelegateImplTest, ConnectToOffscreenPresentation) {
+  content::RenderFrameHost* main_frame = GetWebContents()->GetMainFrame();
+  ASSERT_TRUE(main_frame);
+  int render_process_id = main_frame->GetProcess()->GetID();
+  int render_frame_id = main_frame->GetRoutingID();
+
+  OffscreenPresentationManager* presentation_manager =
+      OffscreenPresentationManagerFactory::
+          GetOrCreateForControllerBrowserContext(GetWebContents());
+
+  content::PresentationSessionInfo session_info(GURL("presentation_url"),

[mark a. foltz, 2016/11/08 23:40:51]

Please use an obviously-valid URL like http://www.example.com/presentation.html

[zhaobin, 2016/11/10 04:14:00]

Done.

+                                                "presentation_id");
+
+  EXPECT_EQ(size_t(0), presentation_manager->offscreen_presentations_.size());
+  content::PresentationConnectionPtr connection;
+  delegate_impl_->ConnectToOffscreenPresentation(
+      render_process_id, render_frame_id, session_info, std::move(connection));
+  EXPECT_EQ(size_t(1), presentation_manager->offscreen_presentations_.size());

[mark a. foltz, 2016/11/08 23:40:51]

It would be a more thorough test to inject a mock
OffscreenPresentationController to verify that RegisterOffscreenPresentation is
called.   However there's a bit of setup required to do it the "standard" way.

The ChromeRenderViewTestHarness constructs a TestingProfile using
CreateBrowserContext(), you can override that to inject a test factory that
returns a mock using TestingProfile::Builder:

https://cs.chromium.org/chromium/src/chrome/test/base/testing_profile.h?rcl=0...

The other way would be to add an API like
OffscreenPresentationManagerFactory::SetInstanceForTest().  However that adds
extra code to the release build.  Derek might have thoughts about this as well
as he's written quite a few tests.

[zhaobin, 2016/11/10 04:14:00]

Done.

+}
+
 }  // namespace media_router