VM: [Kernel] Set types on [LocalVariable] if they were introduced by [VariableDeclaration]s

VM: [Kernel] Set types on [LocalVariable] if they were introduced by [VariableDeclaration]s

R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/4ae06af529bcba94858c04537c00ec70fd6f6ec5

[kustermann, 2016-11-03 13:09:30]

kustermann@google.com changed reviewers:
+ vegorov@google.com

[kustermann, 2016-11-03 13:09:31]

https://codereview.chromium.org/2477563003/diff/1/runtime/vm/kernel_to_il.cc
File runtime/vm/kernel_to_il.cc (right):

https://codereview.chromium.org/2477563003/diff/1/runtime/vm/kernel_to_il.cc#...
runtime/vm/kernel_to_il.cc:321: AbstractType::dynamic_type());
I guess for all synthetic [LocalVariable]s we can use dynamic, since they will
not be involved with any checked-mode tests?

[Vyacheslav Egorov (Google), 2016-11-07 14:05:16]

lgtm

https://codereview.chromium.org/2477563003/diff/20001/runtime/vm/kernel_to_il.cc
File runtime/vm/kernel_to_il.cc (right):

https://codereview.chromium.org/2477563003/diff/20001/runtime/vm/kernel_to_il...
runtime/vm/kernel_to_il.cc:46: // Constructor.
Comment says it's Procedure or a Constructor and there is a IsField there.

In general I find this comment very confusing.

https://codereview.chromium.org/2477563003/diff/20001/runtime/vm/kernel_to_il...
runtime/vm/kernel_to_il.cc:269: dart::Class& klass =
can this be const?

https://codereview.chromium.org/2477563003/diff/20001/runtime/vm/kernel_to_il...
runtime/vm/kernel_to_il.cc:276: // Mark that we are using
[klass]/[kernell_klass] as active class.  Resolving
kernel_klass here and below

"Resolving ... will get resolved"? 

Maybe reword this comment.

https://codereview.chromium.org/2477563003/diff/20001/runtime/vm/kernel_to_il...
runtime/vm/kernel_to_il.cc:280: Member* member = outermost_node != NULL &&
outermost_node->IsMember()
(... != ...)

https://codereview.chromium.org/2477563003/diff/20001/runtime/vm/kernel_to_il...
runtime/vm/kernel_to_il.cc:2798: Member* member = outermost_node != NULL &&
outermost_node->IsMember()
(... != ...)

[kustermann, 2016-11-07 20:22:56]

https://codereview.chromium.org/2477563003/diff/20001/runtime/vm/kernel_to_il.cc
File runtime/vm/kernel_to_il.cc (right):

https://codereview.chromium.org/2477563003/diff/20001/runtime/vm/kernel_to_il...
runtime/vm/kernel_to_il.cc:46: // Constructor.
On 2016/11/07 14:05:16, Vyacheslav Egorov (Google) wrote:
> Comment says it's Procedure or a Constructor and there is a IsField there.
> 
> In general I find this comment very confusing. 

Removed comment.

https://codereview.chromium.org/2477563003/diff/20001/runtime/vm/kernel_to_il...
runtime/vm/kernel_to_il.cc:269: dart::Class& klass =
On 2016/11/07 14:05:16, Vyacheslav Egorov (Google) wrote:
> can this be const?

Done.

https://codereview.chromium.org/2477563003/diff/20001/runtime/vm/kernel_to_il...
runtime/vm/kernel_to_il.cc:276: // Mark that we are using
[klass]/[kernell_klass] as active class.  Resolving
On 2016/11/07 14:05:16, Vyacheslav Egorov (Google) wrote:
> kernel_klass here and below
> 
> "Resolving ... will get resolved"? 
> 
> Maybe reword this comment.

Rephrased.

https://codereview.chromium.org/2477563003/diff/20001/runtime/vm/kernel_to_il...
runtime/vm/kernel_to_il.cc:280: Member* member = outermost_node != NULL &&
outermost_node->IsMember()
On 2016/11/07 14:05:16, Vyacheslav Egorov (Google) wrote:
> (... != ...)

Done.

https://codereview.chromium.org/2477563003/diff/20001/runtime/vm/kernel_to_il...
runtime/vm/kernel_to_il.cc:2798: Member* member = outermost_node != NULL &&
outermost_node->IsMember()
On 2016/11/07 14:05:16, Vyacheslav Egorov (Google) wrote:
> (... != ...)

Done.

[kustermann, 2016-11-08 08:56:28]

Description was changed from

==========
VM: [Kernel] Set types on [LocalVariable] if they were introduced by
[VariableDeclaration]s
==========

to

==========
VM: [Kernel] Set types on [LocalVariable] if they were introduced by
[VariableDeclaration]s

R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4ae06af529bcba94858c04537c00ec70fd6f6ec5
==========

[kustermann, 2016-11-08 08:56:30]

Committed patchset #3 (id:40001) manually as
4ae06af529bcba94858c04537c00ec70fd6f6ec5 (presubmit successful).