Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2477533002:
DEPS in Skia from their actual googlesource host (Closed)
DescriptionDEPS in Skia from their actual googlesource host
There is no reason to rely on googlesource-to-googlesource
mirroring in DEPS files. We already pull directly from the
pdfium, boringssl, swiftshader, and android hosts, so we should
do the same for skia as well.
R=jam@chromium.org, rmistry@chromium.org
BUG=chromium:651068
Committed: https://crrev.com/851c6f72587756eab07e345c2212c0d45c8c10e1
Cr-Commit-Position: refs/heads/master@{#429926}
Patch Set 1 #Patch Set 2 : Rebase #Messages
Total messages: 20 (10 generated)
tandrii@chromium.org changed reviewers: + tandrii@chromium.org
lgtm
Description was changed from ========== DEPS in Skia from their actual googlesource host There is no reason to rely on googlesource-to-googlesource mirroring in DEPS files. We already pull directly from the pdfium, boringssl, swiftshader, and android hosts, so we should do the same for skia as well. R=jam@chromium.org, rmistry@chromium.org ========== to ========== DEPS in Skia from their actual googlesource host There is no reason to rely on googlesource-to-googlesource mirroring in DEPS files. We already pull directly from the pdfium, boringssl, swiftshader, and android hosts, so we should do the same for skia as well. R=jam@chromium.org, rmistry@chromium.org BUG=chromium:651068 ==========
rmistry@google.com changed reviewers: + borenet@google.com, rmistry@google.com
+Eric
Is there much risk that skia.googlesource.com goes down while chromium.googlesource.com stays up? When we first moved to Git and I was changing DEPS for Skia I remember being told that it was preferable to have all of the repos coming from the same place. AFAIK though, GoB is GoB and this shouldn't be an issue. LGTM.
On 2016/11/03 at 11:21:09, borenet wrote: > Is there much risk that skia.googlesource.com goes down while chromium.googlesource.com stays up? When we first moved to Git and I was changing DEPS for Skia I remember being told that it was preferable to have all of the repos coming from the same place. AFAIK though, GoB is GoB and this shouldn't be an issue. LGTM. Yeah, that's exactly the idea. I don't know of a situation in which one goes down while the other stays up. In addition, they have the same global quota configuration, so we're not even risking running up against that.
I don't think you need my review on this..
On 2016/11/03 at 19:30:09, jam wrote: > I don't think you need my review on this.. I totally forgot that DEPS has its own per-file=* line in the top-level OWNERS file. Sorry for the noise.
The CQ bit was checked by agable@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by agable@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from borenet@google.com, tandrii@chromium.org Link to the patchset: https://codereview.chromium.org/2477533002/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== DEPS in Skia from their actual googlesource host There is no reason to rely on googlesource-to-googlesource mirroring in DEPS files. We already pull directly from the pdfium, boringssl, swiftshader, and android hosts, so we should do the same for skia as well. R=jam@chromium.org, rmistry@chromium.org BUG=chromium:651068 ========== to ========== DEPS in Skia from their actual googlesource host There is no reason to rely on googlesource-to-googlesource mirroring in DEPS files. We already pull directly from the pdfium, boringssl, swiftshader, and android hosts, so we should do the same for skia as well. R=jam@chromium.org, rmistry@chromium.org BUG=chromium:651068 Committed: https://crrev.com/851c6f72587756eab07e345c2212c0d45c8c10e1 Cr-Commit-Position: refs/heads/master@{#429926} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/851c6f72587756eab07e345c2212c0d45c8c10e1 Cr-Commit-Position: refs/heads/master@{#429926} |
