Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 2477483002: DevTools: fix breakpoints in Node.js (Closed)

Created:
4 years, 1 month ago by lushnikov
Modified:
4 years, 1 month ago
Reviewers:
kozy, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix breakpoints in Node.js We assume that scripts either have a sane URL. As of today, node.js reports a file path instead of URL - which is not a URL. For this reason, when the script enters DevTools front-end, we convert the file path into URL (with a file:// protocol). This patch additionally starts converting file URLs back to script paths when necessary to support setBreakpointByURL protocol method. BUG=662082 R=dgozman, kozyatinskiy Committed: https://crrev.com/f07ac873c3b8c70d31de57e15d5daac00ab95df7 Cr-Commit-Position: refs/heads/master@{#429661}

Patch Set 1 #

Patch Set 2 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/nodejs-set-breakpoint.html View 1 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/nodejs-set-breakpoint-expected.txt View 1 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
lushnikov
please, take a look
4 years, 1 month ago (2016-11-02 23:22:46 UTC) #1
dgozman
lgtm, but please add a test
4 years, 1 month ago (2016-11-02 23:37:36 UTC) #2
kozy
lgtm, thanks!
4 years, 1 month ago (2016-11-02 23:56:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477483002/20001
4 years, 1 month ago (2016-11-03 17:36:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 19:05:19 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 19:16:30 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f07ac873c3b8c70d31de57e15d5daac00ab95df7
Cr-Commit-Position: refs/heads/master@{#429661}

Powered by Google App Engine
This is Rietveld 408576698