chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc - Issue 2477463003: Replace ui::AXViewState with AXNodeData and AXActionData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

Issue 2477463003: Replace ui::AXViewState with AXNodeData and AXActionData (Closed)

Patch Set: Fix test Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/page_action_with_badge_view.h ('k') | chrome/browser/ui/views/location_bar/zoom_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

diff --git a/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc b/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

index c0be1c9b096539cac166895ca007fedd13045392..c0be46fb93c18d0d494bd8c59cd6924a0b9dc82b 100644

--- a/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

+++ b/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

@@ -6,7 +6,7 @@

#include "chrome/browser/extensions/extension_action.h"

#include "chrome/browser/ui/views/location_bar/page_action_image_view.h"

-#include "ui/accessibility/ax_view_state.h"

+#include "ui/accessibility/ax_node_data.h"

#include "ui/views/layout/fill_layout.h"

PageActionWithBadgeView::PageActionWithBadgeView(

@@ -15,9 +15,8 @@ PageActionWithBadgeView::PageActionWithBadgeView(

SetLayoutManager(new views::FillLayout());

}

-void PageActionWithBadgeView::GetAccessibleState(

- ui::AXViewState* state) {

- state->role = ui::AX_ROLE_GROUP;

+void PageActionWithBadgeView::GetAccessibleNodeData(ui::AXNodeData* node_data) {

+ node_data->role = ui::AX_ROLE_GROUP;

}

gfx::Size PageActionWithBadgeView::GetPreferredSize() const {