Remove stl_util's deletion function use from crypto/.

Remove stl_util's deletion function use from crypto/.

BUG=555865
Committed: https://crrev.com/0eabe32ed2011cd33469f0d5832482ec72e7b27b
Cr-Commit-Position: refs/heads/master@{#429606}

[Avi (use Gerrit), 2016-11-02 22:21:12]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 22:21:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 23:16:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 23:16:58]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-11-03 01:30:24]

avi@chromium.org changed reviewers:
+ davidben@chromium.org

[davidben, 2016-11-03 02:13:48]

davidben@chromium.org changed reviewers:
+ rsleevi@chromium.org

[davidben, 2016-11-03 02:13:49]

Thanks! One question for rsleevi below though, since he'd know better than me if
there's some destruction order assumption here.

https://codereview.chromium.org/2477463002/diff/1/crypto/nss_util.cc
File crypto/nss_util.cc (left):

https://codereview.chromium.org/2477463002/diff/1/crypto/nss_util.cc#oldcode755
crypto/nss_util.cc:755: base::STLDeleteValues(&chromeos_user_map_);
rsleevi: Is there a requirement to clear chromeos_user_map_ before root_ and
chaps_module_ are unloaded? I'm not sure. From InitializeTPMForChromeOSUser and
OnInitializedTPMForChromeOSUser, it looks like the ChromeOSUserData's private
slot might reference chaps_module_?

[Avi (use Gerrit), 2016-11-03 02:17:57]

https://codereview.chromium.org/2477463002/diff/1/crypto/nss_util.cc
File crypto/nss_util.cc (left):

https://codereview.chromium.org/2477463002/diff/1/crypto/nss_util.cc#oldcode755
crypto/nss_util.cc:755: base::STLDeleteValues(&chromeos_user_map_);
On 2016/11/03 02:13:48, davidben wrote:
> rsleevi: Is there a requirement to clear chromeos_user_map_ before root_ and
> chaps_module_ are unloaded? I'm not sure. From InitializeTPMForChromeOSUser
and
> OnInitializedTPMForChromeOSUser, it looks like the ChromeOSUserData's private
> slot might reference chaps_module_?

I can totally put

chromeos_user_map_.clear();

back in if we're not sure.

[davidben, 2016-11-03 02:20:29]

https://codereview.chromium.org/2477463002/diff/1/crypto/nss_util.cc
File crypto/nss_util.cc (left):

https://codereview.chromium.org/2477463002/diff/1/crypto/nss_util.cc#oldcode755
crypto/nss_util.cc:755: base::STLDeleteValues(&chromeos_user_map_);
On 2016/11/03 02:17:57, Avi wrote:
> On 2016/11/03 02:13:48, davidben wrote:
> > rsleevi: Is there a requirement to clear chromeos_user_map_ before root_ and
> > chaps_module_ are unloaded? I'm not sure. From InitializeTPMForChromeOSUser
> and
> > OnInitializedTPMForChromeOSUser, it looks like the ChromeOSUserData's
private
> > slot might reference chaps_module_?
> 
> I can totally put
> 
> chromeos_user_map_.clear();
> 
> back in if we're not sure.

Yeah. I figure we may as well see if Ryan knows definitively and, if it's known
to be required, we can put a comment to this effect.

[Ryan Sleevi, 2016-11-03 03:06:41]

https://codereview.chromium.org/2477463002/diff/1/crypto/nss_util.cc
File crypto/nss_util.cc (left):

https://codereview.chromium.org/2477463002/diff/1/crypto/nss_util.cc#oldcode755
crypto/nss_util.cc:755: base::STLDeleteValues(&chromeos_user_map_);
On 2016/11/03 02:20:29, davidben wrote:
> Yeah. I figure we may as well see if Ryan knows definitively and, if it's
known
> to be required, we can put a comment to this effect.

We'll never hit this, and with the move to make Singletons leaky by default,
really, we should just delete this code (c.f. lines 750-752 - the fact that
willchan's name is on it says a lot)

That said, yes, we need to free those modules before we get to either 763 or
769, so the .clear() is the semantically correct (but entirely unexecuted)
solution.

[Ryan Sleevi, 2016-11-03 03:08:52]

LGTM w/ .clear() added (for now), unless you want to take the more charged task
of just nuking all the shutdown code as part of the ::Leaky-all-the-things
semantics :)

[Avi (use Gerrit), 2016-11-03 15:21:19]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-11-03 15:21:20]

The patchset sent to the CQ was uploaded after l-g-t-m from rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/2477463002/#ps20001
(title: "fix")

[commit-bot: I haz the power, 2016-11-03 15:21:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 16:05:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-03 16:12:00]

Description was changed from

==========
Remove stl_util's deletion function use from crypto/.

BUG=555865
==========

to

==========
Remove stl_util's deletion function use from crypto/.

BUG=555865

Committed: https://crrev.com/0eabe32ed2011cd33469f0d5832482ec72e7b27b
Cr-Commit-Position: refs/heads/master@{#429606}
==========

[commit-bot: I haz the power, 2016-11-03 16:12:01]

Patchset 2 (id:??) landed as
https://crrev.com/0eabe32ed2011cd33469f0d5832482ec72e7b27b
Cr-Commit-Position: refs/heads/master@{#429606}