Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2477453006: Special case the Pixel as not supporting integer division for 32-bit ARM. (Closed)

Created:
4 years, 1 month ago by rmacnak
Modified:
4 years, 1 month ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org, jsimmons1
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Special case the Pixel as not supporting integer division for 32-bit ARM. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/4d81fee396081f68ad33b59845fead0b905bc69d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M runtime/vm/cpu_arm.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
"F1.3.8 Divide instructions In ARMv8, signed and unsigned integer divide instructions are included in both ...
4 years, 1 month ago (2016-11-04 22:03:39 UTC) #2
zra
lgtm This is super weird.
4 years, 1 month ago (2016-11-04 22:21:30 UTC) #3
rmacnak
4 years, 1 month ago (2016-11-04 22:43:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4d81fee396081f68ad33b59845fead0b905bc69d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698