MIPS[64]: Optimize kMips[64]Tst in code-generator-mips[64].cc

src/mips64/macro-assembler-mips64.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <limits.h>  // For LONG_MIN, LONG_MAX.
 
 #if V8_TARGET_ARCH_MIPS64
 
 #include "src/base/division-by-constant.h"
 #include "src/bootstrapper.h"
@@ skipping 1740 matching lines @@
 
 void MacroAssembler::Ext(Register rt,
                          Register rs,
                          uint16_t pos,
                          uint16_t size) {
   DCHECK(pos < 32);
   DCHECK(pos + size < 33);
   ext_(rt, rs, pos, size);
 }
 
+void MacroAssembler::ExtractBits(Register rt, Register rs, uint16_t pos,
+                                 uint16_t size) {
+  DCHECK(pos < 64);
+  DCHECK(size > 0 && size <= 64);
+  DCHECK(pos + size <= 64);
+  if (pos < 32) {
+    if (size <= 32) {
+      Dext(rt, rs, pos, size);
+    } else {
+      Dextm(rt, rs, pos, size);
+    }
+  } else if (pos < 64) {

[miran.karic, 2016/11/10 16:31:56]

This if after else and DCHECK line below are redundant as you have everything
covered with DCHECKs above.

[ivica.bogosavljevic, 2016/11/15 09:14:06]

This is true, but I would like to leave this as it is for two reasons:
1) if anyone changes something above, this check will fail
2) implicitly for the programmer, so he knows that we expect here size to be
less-equal than 32 (this could have been done in the comment though)

+    DCHECK(size <= 32);
+    Dextu(rt, rs, pos, size);
+  }
+}
 
 void MacroAssembler::Dext(Register rt, Register rs, uint16_t pos,
                           uint16_t size) {
   DCHECK(pos < 32);
-  DCHECK(pos + size < 33);
+  DCHECK(size > 0 && size <= 32);
   dext_(rt, rs, pos, size);
 }
 
 
 void MacroAssembler::Dextm(Register rt, Register rs, uint16_t pos,
                            uint16_t size) {
   DCHECK(pos < 32);
-  DCHECK(size <= 64);
+  DCHECK(size > 32 && size <= 64);
+  DCHECK((pos + size) > 32 && (pos + size) <= 64);
   dextm(rt, rs, pos, size);
 }
 
 
 void MacroAssembler::Dextu(Register rt, Register rs, uint16_t pos,
                            uint16_t size) {
   DCHECK(pos >= 32 && pos < 64);
-  DCHECK(size < 33);
+  DCHECK(size > 0 && size <= 32);
+  DCHECK((pos + size) > 32 && (pos + size) <= 64);
   dextu(rt, rs, pos, size);
 }
 
 
 void MacroAssembler::Dins(Register rt, Register rs, uint16_t pos,
                           uint16_t size) {
   DCHECK(pos < 32);
   DCHECK(pos + size <= 32);
   DCHECK(size != 0);
   dins_(rt, rs, pos, size);
@@ skipping 5352 matching lines @@
   if (mag.shift > 0) sra(result, result, mag.shift);
   srl(at, dividend, 31);
   Addu(result, result, Operand(at));
 }
 
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_TARGET_ARCH_MIPS64