MD Settings: Sync route paths in JavaScript to URL constants in C++

chrome/browser/resources/settings/route.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('settings', function() {
   /**
    * Class for navigable routes. May only be instantiated within this file.
    * @constructor
    * @param {string} path
    * @private
@@ skipping 75 matching lines @@
   // Abbreviated variable for easier definitions.
   var r = Route;
 
   // Root pages.
   r.BASIC = new Route('/');
   r.ADVANCED = new Route('/advanced');
   r.ABOUT = new Route('/help');
 
   // Navigable dialogs. These are the only non-section children of root pages.
   // These are disfavored. If we add anymore, we should add explicit support.
-  r.SIGN_OUT = r.BASIC.createChild('/signOut');
-  r.CLEAR_BROWSER_DATA = r.ADVANCED.createChild('/clearBrowserData');
-  r.RESET_DIALOG = r.ADVANCED.createChild('/resetProfileSettings');
-  r.TRIGGERED_RESET_DIALOG =
-      r.ADVANCED.createChild('/triggeredResetProfileSettings');
+  r.SIGN_OUT = r.BASIC.createChild(loadTimeData.getString('signOutPath'));
+  r.CLEAR_BROWSER_DATA = r.ADVANCED.createChild(
+      loadTimeData.getString('clearBrowserDataPath'));
+  r.RESET_DIALOG = r.ADVANCED.createChild(
+      loadTimeData.getString('resetProfileSettingsPath'));
+  r.TRIGGERED_RESET_DIALOG = r.ADVANCED.createChild(
+      loadTimeData.getString('triggeredResetProfileSettingsPath'));
 
 <if expr="chromeos">
-  r.INTERNET = r.BASIC.createSection('/internet', 'internet');
+  r.INTERNET = r.BASIC.createSection(
+      loadTimeData.getString('internetPath'), 'internet');
   r.NETWORK_DETAIL = r.INTERNET.createChild('/networkDetail');
   r.KNOWN_NETWORKS = r.INTERNET.createChild('/knownNetworks');
 </if>
 
   r.APPEARANCE = r.BASIC.createSection('/appearance', 'appearance');
   r.FONTS = r.APPEARANCE.createChild('/fonts');
 
   r.DEFAULT_BROWSER =
       r.BASIC.createSection('/defaultBrowser', 'defaultBrowser');
 
   r.SEARCH = r.BASIC.createSection('/search', 'search');
-  r.SEARCH_ENGINES = r.SEARCH.createChild('/searchEngines');
+  r.SEARCH_ENGINES =
+      r.SEARCH.createChild(loadTimeData.getString('searchEnginesPath'));
 
   r.ON_STARTUP = r.BASIC.createSection('/onStartup', 'onStartup');
 
   r.PEOPLE = r.BASIC.createSection('/people', 'people');
-  r.SYNC = r.PEOPLE.createChild('/syncSetup');
+  r.SYNC = r.PEOPLE.createChild(loadTimeData.getString('syncSetupPath'));
 <if expr="not chromeos">
-  r.MANAGE_PROFILE = r.PEOPLE.createChild('/manageProfile');
+  r.MANAGE_PROFILE =
+      r.PEOPLE.createChild(loadTimeData.getString('manageProfilePath'));
 </if>
 <if expr="chromeos">
   r.CHANGE_PICTURE = r.PEOPLE.createChild('/changePicture');
   r.ACCOUNTS = r.PEOPLE.createChild('/accounts');
   r.LOCK_SCREEN = r.PEOPLE.createChild('/lockScreen');
 
   r.DEVICE = r.BASIC.createSection('/device', 'device');
   r.POINTERS = r.DEVICE.createChild('/pointer-overlay');
   r.KEYBOARD = r.DEVICE.createChild('/keyboard-overlay');
   r.DISPLAY = r.DEVICE.createChild('/display');
   r.STYLUS = r.DEVICE.createChild('/stylus');
   r.STORAGE = r.DEVICE.createChild('/storage');
 </if>
 
   r.PRIVACY = r.ADVANCED.createSection('/privacy', 'privacy');
   r.CERTIFICATES = r.PRIVACY.createChild('/certificates');
 
-  r.SITE_SETTINGS = r.PRIVACY.createChild('/content');
+  r.SITE_SETTINGS =
+      r.PRIVACY.createChild(loadTimeData.getString('contentPath'));
   r.SITE_SETTINGS_ALL = r.SITE_SETTINGS.createChild('all');
-  r.SITE_SETTINGS_SITE_DETAILS =
-      r.SITE_SETTINGS_ALL.createChild('/content/siteDetails');
+  r.SITE_SETTINGS_SITE_DETAILS = r.SITE_SETTINGS_ALL.createChild(
+      loadTimeData.getString('contentPath') + '/siteDetails');
 
-  r.SITE_SETTINGS_HANDLERS = r.SITE_SETTINGS.createChild('/handlers');
+  r.SITE_SETTINGS_HANDLERS = r.SITE_SETTINGS.createChild(
+      loadTimeData.getString('handlersPath'));
 
   // TODO(tommycli): Find a way to refactor these repetitive category routes.
   r.SITE_SETTINGS_AUTOMATIC_DOWNLOADS =
       r.SITE_SETTINGS.createChild('automaticDownloads');
   r.SITE_SETTINGS_BACKGROUND_SYNC =
       r.SITE_SETTINGS.createChild('backgroundSync');
   r.SITE_SETTINGS_CAMERA = r.SITE_SETTINGS.createChild('camera');
   r.SITE_SETTINGS_COOKIES = r.SITE_SETTINGS.createChild('cookies');
   r.SITE_SETTINGS_DATA_DETAILS =
       r.SITE_SETTINGS_COOKIES.createChild('/cookies/detail');
   r.SITE_SETTINGS_IMAGES = r.SITE_SETTINGS.createChild('images');
   r.SITE_SETTINGS_JAVASCRIPT = r.SITE_SETTINGS.createChild('javascript');
   r.SITE_SETTINGS_KEYGEN = r.SITE_SETTINGS.createChild('keygen');
   r.SITE_SETTINGS_LOCATION = r.SITE_SETTINGS.createChild('location');
   r.SITE_SETTINGS_MICROPHONE = r.SITE_SETTINGS.createChild('microphone');
   r.SITE_SETTINGS_NOTIFICATIONS = r.SITE_SETTINGS.createChild('notifications');
   r.SITE_SETTINGS_FLASH = r.SITE_SETTINGS.createChild('flash');
   r.SITE_SETTINGS_POPUPS = r.SITE_SETTINGS.createChild('popups');
   r.SITE_SETTINGS_UNSANDBOXED_PLUGINS =
       r.SITE_SETTINGS.createChild('unsandboxedPlugins');
   r.SITE_SETTINGS_USB_DEVICES = r.SITE_SETTINGS.createChild('usbDevices');
   r.SITE_SETTINGS_ZOOM_LEVELS = r.SITE_SETTINGS.createChild('zoomLevels');
 
 <if expr="chromeos">
-  r.DATETIME = r.ADVANCED.createSection('/dateTime', 'dateTime');
-  r.BLUETOOTH = r.ADVANCED.createSection('/bluetooth', 'bluetooth');
+  r.DATETIME = r.ADVANCED.createSection(
+      loadTimeData.getString('dateTimePath'), 'dateTime');
+  r.BLUETOOTH = r.ADVANCED.createSection(
+      loadTimeData.getString('bluetoothPath'), 'bluetooth');
 </if>
 
   r.PASSWORDS =
       r.ADVANCED.createSection('/passwordsAndForms', 'passwordsAndForms');
-  r.AUTOFILL = r.PASSWORDS.createChild('/autofill');
-  r.MANAGE_PASSWORDS = r.PASSWORDS.createChild('/passwords');
+  r.AUTOFILL = r.PASSWORDS.createChild(loadTimeData.getString('autofillPath'));
+  r.MANAGE_PASSWORDS =
+      r.PASSWORDS.createChild(loadTimeData.getString('passwordsPath'));
 
-  r.LANGUAGES = r.ADVANCED.createSection('/languages', 'languages');
+  r.LANGUAGES = r.ADVANCED.createSection(
+      loadTimeData.getString('languagesPath'), 'languages');
 <if expr="chromeos">
   r.INPUT_METHODS = r.LANGUAGES.createChild('/inputMethods');
 </if>
 <if expr="not is_macosx">
   r.EDIT_DICTIONARY = r.LANGUAGES.createChild('/editDictionary');
 </if>
 
   r.DOWNLOADS = r.ADVANCED.createSection('/downloadsDirectory', 'downloads');
 
   r.PRINTING = r.ADVANCED.createSection('/printing', 'printing');
   r.CLOUD_PRINTERS = r.PRINTING.createChild('/cloudPrinters');
 <if expr="chromeos">
   r.CUPS_PRINTERS = r.PRINTING.createChild('/cupsPrinters');
   r.CUPS_PRINTER_DETAIL = r.CUPS_PRINTERS.createChild('/cupsPrinterDetails');
 </if>
 
-  r.ACCESSIBILITY = r.ADVANCED.createSection('/accessibility', 'a11y');
+  r.ACCESSIBILITY = r.ADVANCED.createSection(
+      loadTimeData.getString('accessibilityPath'), 'a11y');
   r.MANAGE_ACCESSIBILITY = r.ACCESSIBILITY.createChild('/manageAccessibility');
 
   r.SYSTEM = r.ADVANCED.createSection('/system', 'system');
   r.RESET = r.ADVANCED.createSection('/reset', 'reset');
 
 <if expr="chromeos">
   // "About" is the only section in About, but we still need to create the route
   // in order to show the subpage on Chrome OS.
   r.ABOUT_ABOUT = r.ABOUT.createSection('/help/about', 'about');
   r.DETAILED_BUILD_INFO = r.ABOUT_ABOUT.createChild('/help/details');
@@ skipping 155 matching lines @@
     RouteObserverBehavior: RouteObserverBehavior,
     getRouteForPath: getRouteForPath,
     initializeRouteFromUrl: initializeRouteFromUrl,
     getCurrentRoute: getCurrentRoute,
     getQueryParameters: getQueryParameters,
     lastRouteChangeWasPopstate: lastRouteChangeWasPopstate,
     navigateTo: navigateTo,
     navigateToPreviousRoute: navigateToPreviousRoute,
   };
 });