Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2477423002: [ios] Removes calls to the deprecated GetAvailableVoiceSearchLanguages(). (Closed)

Created:
4 years, 1 month ago by rohitrao (ping after 24h)
Modified:
4 years, 1 month ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removes calls to the deprecated GetAvailableVoiceSearchLanguages(). BUG=656617 Committed: https://crrev.com/3bd77d8cd3d2c36cacabb0a2df8c3f3ab6bd8d2e Cr-Commit-Position: refs/heads/master@{#430339}

Patch Set 1 #

Patch Set 2 : Fix compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ios/chrome/browser/voice/speech_input_locale_config_impl.mm View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
rohitrao (ping after 24h)
First in a series of cleanup CLs.
4 years, 1 month ago (2016-11-07 18:46:15 UTC) #4
kkhorimoto
lgtm
4 years, 1 month ago (2016-11-07 18:47:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477423002/20001
4 years, 1 month ago (2016-11-07 19:14:28 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-07 19:21:52 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 19:35:09 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3bd77d8cd3d2c36cacabb0a2df8c3f3ab6bd8d2e
Cr-Commit-Position: refs/heads/master@{#430339}

Powered by Google App Engine
This is Rietveld 408576698