Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2477393003: Make SurfaceFactory lifetime match frame_sink_id_ registration in Android WebView (Closed)

Created:
4 years, 1 month ago by piman
Modified:
4 years, 1 month ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make SurfaceFactory lifetime match frame_sink_id_ registration in Android WebView This will allow further simplification/refactoring. BUG=657959 Committed: https://crrev.com/dc6b7bfdc4cc7c84bf4b9efb15f7631125b3678d Cr-Commit-Position: refs/heads/master@{#430404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M android_webview/browser/hardware_renderer.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M android_webview/browser/surfaces_instance.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
piman
4 years, 1 month ago (2016-11-07 22:14:48 UTC) #3
boliu
lgtm
4 years, 1 month ago (2016-11-07 22:23:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477393003/1
4 years, 1 month ago (2016-11-07 22:33:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 22:43:06 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 23:01:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc6b7bfdc4cc7c84bf4b9efb15f7631125b3678d
Cr-Commit-Position: refs/heads/master@{#430404}

Powered by Google App Engine
This is Rietveld 408576698