[Tools] Enable grouping of jited code in linux_perf_report.py.

[Tools] Enable grouping of jited code in linux_perf_report.py.

Committed: https://crrev.com/4bc082f360d424b60720175639af8575a0c1ef3a
Cr-Commit-Position: refs/heads/master@{#40823}

[rmcilroy, 2016-11-07 14:45:26]

rmcilroy@chromium.org changed reviewers:
+ mythria@chromium.org

[rmcilroy, 2016-11-07 14:45:27]

Mythri, PTAL, thanks.

[mythria, 2016-11-07 14:50:43]

Thanks, lgtm.

[rmcilroy, 2016-11-07 15:22:10]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2016-11-07 15:22:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 15:25:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 15:25:45]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/27980)

[mythria, 2016-11-08 09:47:08]

just one fix when handling unknown symbols.

https://codereview.chromium.org/2477363002/diff/1/tools/ignition/linux_perf_r...
File tools/ignition/linux_perf_report.py (right):

https://codereview.chromium.org/2477363002/diff/1/tools/ignition/linux_perf_r...
tools/ignition/linux_perf_report.py:110: if symbol == "[unknown]" and
current_chain[-1] == "[unknown]":
It is possible that symbol is unknown and the current_chain is empty. So may be
we can change this to:
symbol == "[unknown]" and (len(current_chain) == 0 or current_chain[-1] ==
"[unknown]"):

[rmcilroy, 2016-11-08 10:18:01]

On 2016/11/08 09:47:08, mythria wrote:
> just one fix when handling unknown symbols.
> 
>
https://codereview.chromium.org/2477363002/diff/1/tools/ignition/linux_perf_r...
> File tools/ignition/linux_perf_report.py (right):
> 
>
https://codereview.chromium.org/2477363002/diff/1/tools/ignition/linux_perf_r...
> tools/ignition/linux_perf_report.py:110: if symbol == "[unknown]" and
> current_chain[-1] == "[unknown]":
> It is possible that symbol is unknown and the current_chain is empty. So may
be
> we can change this to:
> symbol == "[unknown]" and (len(current_chain) == 0 or current_chain[-1] ==
> "[unknown]"):

Good point, done. thanks.

[rmcilroy, 2016-11-08 10:18:14]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-11-08 10:18:14]

The patchset sent to the CQ was uploaded after l-g-t-m from mythria@chromium.org
Link to the patchset: https://codereview.chromium.org/2477363002/#ps20001
(title: "Add fix")

[commit-bot: I haz the power, 2016-11-08 10:18:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 10:37:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:25:39]

Description was changed from

==========
[Tools] Enable grouping of jited code in linux_perf_report.py.
==========

to

==========
[Tools] Enable grouping of jited code in linux_perf_report.py.

Committed: https://crrev.com/4bc082f360d424b60720175639af8575a0c1ef3a
Cr-Commit-Position: refs/heads/master@{#40823}
==========

[commit-bot: I haz the power, 2016-11-17 22:25:40]

Patchset 2 (id:??) landed as
https://crrev.com/4bc082f360d424b60720175639af8575a0c1ef3a
Cr-Commit-Position: refs/heads/master@{#40823}