Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2477353002: Convert editing/spelling/spelling-double-clicked-word[-with-underscores].html with spellcheck_test (Closed)

Created:
4 years, 1 month ago by Xiaocheng
Modified:
4 years, 1 month ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/spelling/spelling-double-clicked-word[-with-underscores].html with spellcheck_test This patch converts editing/spelling/spelling-double-clicked-word.html and editing/spelling/spelling-double-clicked-word-with-underscores.html with spellcheck_test as a preparation for implementing idle time spell checker. This patch also merges the two tests into context_click_on_selected_misspelling.html for code health. BUG=517298 Committed: https://crrev.com/6602383f3356abc6b4c45f70849715609aabe4fa Cr-Commit-Position: refs/heads/master@{#430510}

Patch Set 1 #

Messages

Total messages: 14 (9 generated)
Xiaocheng
PTAL.
4 years, 1 month ago (2016-11-08 01:54:01 UTC) #8
yosin_UTC9
lgtm
4 years, 1 month ago (2016-11-08 03:44:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477353002/1
4 years, 1 month ago (2016-11-08 03:44:19 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 03:50:18 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 03:55:22 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6602383f3356abc6b4c45f70849715609aabe4fa
Cr-Commit-Position: refs/heads/master@{#430510}

Powered by Google App Engine
This is Rietveld 408576698