Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2291)

Unified Diff: appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py

Issue 2477343003: [Findit] Refactoring monitor swarming task pipelines (Closed)
Patch Set: Addressing comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py
diff --git a/appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py b/appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py
index 9f94f76b7fa0c7099902221ae680ee3ce1039408..89d0b92acdec4d7652d4be981c6ba71df36870ad 100644
--- a/appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py
+++ b/appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py
@@ -208,7 +208,7 @@ class ProcessFlakeSwarmingTaskResultPipelineTest(wf_testcase.WaterfallTestCase):
return _SAMPLE_FAILURE_LOG
def testProcessFlakeSwarmingTaskResultPipeline(self):
-
+ # End to end test.
self.mock(swarming_util, 'GetSwarmingTaskFailureLog',
self._MockedGetSwarmingTaskFailureLog)
@@ -245,55 +245,3 @@ class ProcessFlakeSwarmingTaskResultPipelineTest(wf_testcase.WaterfallTestCase):
task.started_time)
self.assertEqual(datetime.datetime(2016, 2, 10, 18, 33, 9),
task.completed_time)
-
- def testProcessFlakeSwarmingTaskResultPipelineTaskNotRunning(self):
- task = FlakeSwarmingTask.Create(
- self.master_name, self.builder_name,
- self.build_number, self.step_name, self.test_name)
- task.task_id = 'task_id2'
- task.put()
-
- analysis = MasterFlakeAnalysis.Create(
- self.master_name, self.builder_name,
- self.build_number, self.step_name, self.test_name)
- analysis.Save()
-
- pipeline = ProcessFlakeSwarmingTaskResultPipeline()
- step_name, task_info = pipeline.run(
- self.master_name, self.builder_name, self.build_number, self.step_name,
- 'task_id2', self.build_number, self.test_name, analysis.version_number)
- self.assertEqual(None, task_info)
- self.assertEqual(self.step_name, step_name)
-
- task = FlakeSwarmingTask.Get(
- self.master_name, self.builder_name, self.build_number, self.step_name,
- self.test_name)
-
- self.assertEqual(analysis_status.ERROR, task.status)
-
- def testProcessFlakeSwarmingTaskResultPipelineTaskTimeOut(self):
- # Override swarming config settings to force a timeout.
- override_swarming_settings = {
- 'task_timeout_hours': -1
- }
- self.UpdateUnitTestConfigSettings(
- 'swarming_settings', override_swarming_settings)
-
- task = FlakeSwarmingTask.Create(
- self.master_name, self.builder_name, self.build_number, self.step_name,
- self.test_name)
- task.task_id = 'task_id1'
- task.put()
-
- pipeline = ProcessFlakeSwarmingTaskResultPipeline()
- step_name, task_info = pipeline.run(
- self.master_name, self.builder_name, self.build_number, self.step_name,
- 'task_id1', self.build_number, self.test_name, self.version_number)
- self.assertEqual('abc_tests', task_info)
- self.assertEqual(self.step_name, step_name)
-
- task = FlakeSwarmingTask.Get(
- self.master_name, self.builder_name, self.build_number, self.step_name,
- self.test_name)
- self.assertEqual(analysis_status.ERROR, task.status)
- self.assertEqual({}, task.tests_statuses)

Powered by Google App Engine
This is Rietveld 408576698