[Findit] Refactoring monitor swarming task pipelines

appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py

Index: appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py
diff --git a/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py b/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py
index e89ae89c12c9a887983b74cb0512d5204f0bb8c2..625212abc95946c5a9f24274faa1e253c67b253f 100644
--- a/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py
+++ b/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py
@@ -21,6 +21,22 @@ class ProcessFlakeSwarmingTaskResultPipeline(
   generate a dict for statuses for each test run.
   """
 
+  def _GetArgs(self, master_name, builder_name, build_number,
+               step_name, *args):
+    master_build_number = args[0]
+    test_name = args[1]
+    version_number = args[2]
+    return (master_name, builder_name, build_number, step_name,
+            master_build_number, test_name, version_number)
+
+  # Unused Argument - pylint: disable=W0612,W0613
+  # Arguments number differs from overridden method - pylint: disable=W0221
+  def _GetSwarmingTask(self, master_name, builder_name, build_number,
+                       step_name, master_build_number, test_name, _):
+    # Gets the appropriate kind of swarming task (FlakeSwarmingTask).
+    return FlakeSwarmingTask.Get(master_name, builder_name, build_number,
+                                 step_name, test_name)
+
   # Arguments number differs from overridden method - pylint: disable=W0221
   def _CheckTestsRunStatuses(self, output_json, master_name,
                              builder_name, build_number, step_name,
@@ -93,17 +109,9 @@ class ProcessFlakeSwarmingTaskResultPipeline(
     master_flake_analysis.put()
     return tests_statuses
 
-  def _GetArgs(self, master_name, builder_name, build_number,
-               step_name, *args):
-    master_build_number = args[0]
-    test_name = args[1]
-    version_number = args[2]
-    return (master_name, builder_name, build_number, step_name,
-            master_build_number, test_name, version_number)
-
-  # Unused Argument - pylint: disable=W0612,W0613
-  def _GetSwarmingTask(self, master_name, builder_name, build_number,
-                       step_name, master_build_number, test_name, _):
-    # Get the appropriate kind of Swarming Task (Flake).
-    return FlakeSwarmingTask.Get(master_name, builder_name,
-                                 build_number, step_name, test_name)
+  def run(self, master_name, builder_name, build_number, step_name, task_id,

[chanli, 2016/11/08 19:26:00]

I think there is no need to change this class...

[lijeffrey, 2016/11/08 21:45:00]

Done.

+          *args):
+    call_args = self._GetArgs(master_name, builder_name, build_number,
+                              step_name, *args)
+    step_name_no_platform = self._MonitorSwarmingTask(task_id, *call_args)
+    return step_name, step_name_no_platform