Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2477333002: views: remove obsolete TabbedPane vertical padding (Closed)

Created:
4 years, 1 month ago by Elly Fong-Jones
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views: remove obsolete TabbedPane vertical padding This was removed some weeks ago in an update to the Harmony spec, but the code was never updated to match. BUG=635176 Committed: https://crrev.com/4ae1b75dca27b4a7d8e7e82b4f2f586e3251dd0f Cr-Commit-Position: refs/heads/master@{#430324}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M ui/views/controls/tabbed_pane/tabbed_pane.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Elly Fong-Jones
sky: ptal? :)
4 years, 1 month ago (2016-11-07 12:17:42 UTC) #3
sky
LGTM
4 years, 1 month ago (2016-11-07 17:02:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477333002/1
4 years, 1 month ago (2016-11-07 17:37:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 18:48:55 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 18:56:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ae1b75dca27b4a7d8e7e82b4f2f586e3251dd0f
Cr-Commit-Position: refs/heads/master@{#430324}

Powered by Google App Engine
This is Rietveld 408576698