Stop suspending the pipeline before HaveFutureData while decoding

Stop suspending the pipeline before HaveFutureData while decoding

Previously we could suspend the pipeline before HaveFutureData but
after the media had been completely loaded, relying on the assumption
that we could use the signal of didLoadingProgress() to resume and check
if the new data got us to HaveFutureData. However, if the media is
completely downloaded, there will be no more didLoadingProgress() calls
which meant we could leave the player suspended forever.

Now we check whether loading is stalled (didLoadingProgress() has not
returned true for least 3 seconds) before suspending before
HaveFutureData. If loading is stalled but we haven't reached
HaveFutureData we assume that the pipeline is waiting for more data to
complete preroll.

BUG=655630
TEST=new tests

Review-Url: https://codereview.chromium.org/2445533002
Cr-Commit-Position: refs/heads/master@{#430086}
(cherry picked from commit d026f79cc5949df6bae399f58128b470f8061ad7)

Committed: https://chromium.googlesource.com/chromium/src/+/7aae49babcf9acaa0f549fc5d996945a8aba192d

[watk, 2016-11-07 19:55:56]

Description was changed from

==========
Stop suspending the pipeline before HaveFutureData while decoding

Previously we could suspend the pipeline before HaveFutureData but
after the media had been completely loaded, relying on the assumption
that we could use the signal of didLoadingProgress() to resume and check
if the new data got us to HaveFutureData. However, if the media is
completely downloaded, there will be no more didLoadingProgress() calls
which meant we could leave the player suspended forever.

Now we check whether loading is stalled (didLoadingProgress() has not
returned true for least 3 seconds) before suspending before
HaveFutureData. If loading is stalled but we haven't reached
HaveFutureData we assume that the pipeline is waiting for more data to
complete preroll.

BUG=655630
TEST=new tests

Review-Url: https://codereview.chromium.org/2445533002
Cr-Commit-Position: refs/heads/master@{#430086}
(cherry picked from commit d026f79cc5949df6bae399f58128b470f8061ad7)
==========

to

==========
Stop suspending the pipeline before HaveFutureData while decoding

Previously we could suspend the pipeline before HaveFutureData but
after the media had been completely loaded, relying on the assumption
that we could use the signal of didLoadingProgress() to resume and check
if the new data got us to HaveFutureData. However, if the media is
completely downloaded, there will be no more didLoadingProgress() calls
which meant we could leave the player suspended forever.

Now we check whether loading is stalled (didLoadingProgress() has not
returned true for least 3 seconds) before suspending before
HaveFutureData. If loading is stalled but we haven't reached
HaveFutureData we assume that the pipeline is waiting for more data to
complete preroll.

BUG=655630
TEST=new tests

Review-Url: https://codereview.chromium.org/2445533002
Cr-Commit-Position: refs/heads/master@{#430086}
(cherry picked from commit d026f79cc5949df6bae399f58128b470f8061ad7)

Committed:
https://chromium.googlesource.com/chromium/src/+/7aae49babcf9acaa0f549fc5d996...
==========

[watk, 2016-11-07 19:55:58]

Committed patchset #1 (id:1) manually as
7aae49babcf9acaa0f549fc5d996945a8aba192d.