Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2477323002: Revert of arc: Fix default app availability reporting. (Closed)

Created:
4 years, 1 month ago by kinaba
Modified:
4 years, 1 month ago
Reviewers:
hidehiko, xiyuan, khmel
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, Matt Giuca
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of arc: Fix default app availability reporting. (patchset #1 id:1 of https://codereview.chromium.org/2468973006/ ) Reason for revert: It's breaking all ARC CTS autotests b/32660818, and I highly suspect it is also affecting the Chrome OS CQ crbug.com/662451. BUG=b/32660818 Original issue's description: > arc: Fix default app availability reporting. > > This solves the case when App list model is created before > ArcAppListPrefs and notifications about defualt apps are > not dispatched. > > BUG=641535 > TEST=Locally on device. > > Committed: https://crrev.com/fdae64e689c5c1424d5da8f827e9d1d10d905c1c > Cr-Commit-Position: refs/heads/master@{#429408} TBR=xiyuan@chromium.org,hidehiko@chromium.org,khmel@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=641535 Committed: https://crrev.com/43ff56fd70f2ae8827bf8caa80b16f94040c4f0e Cr-Commit-Position: refs/heads/master@{#430238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 5 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kinaba
Created Revert of arc: Fix default app availability reporting.
4 years, 1 month ago (2016-11-07 08:05:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477323002/1
4 years, 1 month ago (2016-11-07 08:05:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 09:09:42 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/43ff56fd70f2ae8827bf8caa80b16f94040c4f0e Cr-Commit-Position: refs/heads/master@{#430238}
4 years, 1 month ago (2016-11-07 09:13:43 UTC) #7
khmel
4 years, 1 month ago (2016-11-16 22:25:37 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2510933002/ by khmel@chromium.org.

The reason for reverting is: Arc integration tests were fixed and now it is
possible to reland reverted CL.

Powered by Google App Engine
This is Rietveld 408576698