Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2477313003: [NTP] Remove unused resource string and TODOs. (Closed)

Created:
4 years, 1 month ago by vitaliii
Modified:
4 years, 1 month ago
Reviewers:
Marc Treib
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP] Remove unused resource string and TODOs. Due to crbug.com/660343 we could not remove an unused resource string, which is finally removed in this CL. Also an obsolete TODO related to crbug.com/641568 is removed (offline pages are now opened correctly, see crbug.com/661214). BUG=none Committed: https://crrev.com/a97c47f198d8d93933078e9f78a659ef88b3e979 Cr-Commit-Position: refs/heads/master@{#430273}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/browser/ntp_snippets/download_suggestions_provider.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/ntp_snippets_strings.grdp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
vitaliii
Hi Marc, could you have a look please?
4 years, 1 month ago (2016-11-07 14:04:51 UTC) #2
Marc Treib
lgtm Yay!
4 years, 1 month ago (2016-11-07 14:30:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477313003/1
4 years, 1 month ago (2016-11-07 14:49:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 14:54:30 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 14:58:14 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a97c47f198d8d93933078e9f78a659ef88b3e979
Cr-Commit-Position: refs/heads/master@{#430273}

Powered by Google App Engine
This is Rietveld 408576698