Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2477243002: [ios] Makes IOSChromeUnitTestSuite inherit from web::WebTestSuite. (Closed)

Created:
4 years, 1 month ago by rohitrao (ping after 24h)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org, markusheintz_
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Makes IOSChromeUnitTestSuite inherit from web::WebTestSuite. BUG=None TEST=None Committed: https://crrev.com/974ae20b584b388edc4209124fc7dda83f4bb469 Cr-Commit-Position: refs/heads/master@{#430263}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -24 lines) Patch
M ios/chrome/test/BUILD.gn View 1 2 chunks +2 lines, -1 line 0 comments Download
M ios/chrome/test/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/test/ios_chrome_unit_test_suite.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/chrome/test/ios_chrome_unit_test_suite.mm View 4 chunks +8 lines, -20 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
rohitrao (ping after 24h)
+sdefresne for review +markusheintz for OWNERS approval of the new DEPS addition Thanks!
4 years, 1 month ago (2016-11-07 02:04:38 UTC) #4
sdefresne
lgtm https://codereview.chromium.org/2477243002/diff/1/ios/chrome/test/BUILD.gn File ios/chrome/test/BUILD.gn (right): https://codereview.chromium.org/2477243002/diff/1/ios/chrome/test/BUILD.gn#newcode22 ios/chrome/test/BUILD.gn:22: "//base/test:test_support", Is this dependency still required?
4 years, 1 month ago (2016-11-07 09:01:39 UTC) #7
rohitrao (ping after 24h)
@markusheintz could you please look at the DEPS addition when you get a chance? Thanks! ...
4 years, 1 month ago (2016-11-07 12:49:52 UTC) #10
markusheintz_
Martin should probably have a look at this.
4 years, 1 month ago (2016-11-07 13:24:26 UTC) #12
msramek
LGTM. We have recently sanitized some platform-specific stuff in content settings code, so it should ...
4 years, 1 month ago (2016-11-07 13:35:29 UTC) #15
rohitrao (ping after 24h)
On 2016/11/07 13:35:29, msramek wrote: > LGTM. We have recently sanitized some platform-specific stuff in ...
4 years, 1 month ago (2016-11-07 13:41:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477243002/20001
4 years, 1 month ago (2016-11-07 13:41:47 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-07 13:46:35 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 13:49:44 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/974ae20b584b388edc4209124fc7dda83f4bb469
Cr-Commit-Position: refs/heads/master@{#430263}

Powered by Google App Engine
This is Rietveld 408576698