[ios] Makes IOSChromeUnitTestSuite inherit from web::WebTestSuite.

[ios] Makes IOSChromeUnitTestSuite inherit from web::WebTestSuite.

BUG=None
TEST=None

Committed: https://crrev.com/974ae20b584b388edc4209124fc7dda83f4bb469
Cr-Commit-Position: refs/heads/master@{#430263}

[rohitrao (ping after 24h), 2016-11-07 01:56:49]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 01:56:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rohitrao (ping after 24h), 2016-11-07 02:04:37]

rohitrao@chromium.org changed reviewers:
+ markusheintz@chromium.org, sdefresne@chromium.org

[rohitrao (ping after 24h), 2016-11-07 02:04:38]

+sdefresne for review

+markusheintz for OWNERS approval of the new DEPS addition

Thanks!

[commit-bot: I haz the power, 2016-11-07 02:59:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 02:59:11]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-11-07 09:01:39]

lgtm

https://codereview.chromium.org/2477243002/diff/1/ios/chrome/test/BUILD.gn
File ios/chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2477243002/diff/1/ios/chrome/test/BUILD.gn#ne...
ios/chrome/test/BUILD.gn:22: "//base/test:test_support",
Is this dependency still required?

[rohitrao (ping after 24h), 2016-11-07 12:49:20]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 12:49:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rohitrao (ping after 24h), 2016-11-07 12:49:52]

@markusheintz could you please look at the DEPS addition when you get a chance? 
Thanks!

https://codereview.chromium.org/2477243002/diff/1/ios/chrome/test/BUILD.gn
File ios/chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2477243002/diff/1/ios/chrome/test/BUILD.gn#ne...
ios/chrome/test/BUILD.gn:22: "//base/test:test_support",
On 2016/11/07 09:01:38, sdefresne wrote:
> Is this dependency still required?

"gn check" says no.  Removed.

[markusheintz_, 2016-11-07 13:24:25]

markusheintz@chromium.org changed reviewers:
+ msramek@chromium.org

[markusheintz_, 2016-11-07 13:24:26]

Martin should probably have a look at this.

[commit-bot: I haz the power, 2016-11-07 13:31:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 13:31:32]

Dry run: This issue passed the CQ dry run.

[msramek, 2016-11-07 13:35:29]

LGTM. We have recently sanitized some platform-specific stuff in content
settings code, so it should be safe to depend on it from iOS.

[rohitrao (ping after 24h), 2016-11-07 13:41:27]

On 2016/11/07 13:35:29, msramek wrote:
> LGTM. We have recently sanitized some platform-specific stuff in content
> settings code, so it should be safe to depend on it from iOS.

Really excited to hear this =)  Thanks for the review!

[rohitrao (ping after 24h), 2016-11-07 13:41:32]

The CQ bit was checked by rohitrao@chromium.org

[rohitrao (ping after 24h), 2016-11-07 13:41:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2477243002/#ps20001
(title: "Review.")

[commit-bot: I haz the power, 2016-11-07 13:41:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 13:46:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-07 13:49:42]

Description was changed from

==========
[ios] Makes IOSChromeUnitTestSuite inherit from web::WebTestSuite.

BUG=None
TEST=None
==========

to

==========
[ios] Makes IOSChromeUnitTestSuite inherit from web::WebTestSuite.

BUG=None
TEST=None

Committed: https://crrev.com/974ae20b584b388edc4209124fc7dda83f4bb469
Cr-Commit-Position: refs/heads/master@{#430263}
==========

[commit-bot: I haz the power, 2016-11-07 13:49:44]

Patchset 2 (id:??) landed as
https://crrev.com/974ae20b584b388edc4209124fc7dda83f4bb469
Cr-Commit-Position: refs/heads/master@{#430263}