Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 2477223002: Reland of Use the serviceworker with mojo by default (Closed)
Patch Set: Rebase for navigation-preload Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_browsertest.cc
diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc
index 59aa3d4d20b087b604675c4a277116ecc8973b1f..2504b081d2f95759616ee82585ecfa9ab3449225 100644
--- a/content/browser/service_worker/service_worker_browsertest.cc
+++ b/content/browser/service_worker/service_worker_browsertest.cc
@@ -385,20 +385,11 @@ bool CheckHeader(const base::DictionaryValue& dict,
} // namespace
-class ServiceWorkerBrowserTest : public testing::WithParamInterface<bool>,
- public ContentBrowserTest {
+class ServiceWorkerBrowserTest
+ : public MojoServiceWorkerTestP<ContentBrowserTest> {
protected:
using self = ServiceWorkerBrowserTest;
- void SetUp() override {
- is_mojo_enabled_ = GetParam();
- if (is_mojo_enabled()) {
- base::CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kMojoServiceWorker);
- }
- ContentBrowserTest::SetUp();
- }
-
void SetUpOnMainThread() override {
ASSERT_TRUE(embedded_test_server()->Start());
StoragePartition* partition = BrowserContext::GetDefaultStoragePartition(
@@ -426,7 +417,6 @@ class ServiceWorkerBrowserTest : public testing::WithParamInterface<bool>,
ServiceWorkerContextWrapper* wrapper() { return wrapper_.get(); }
ServiceWorkerContext* public_context() { return wrapper(); }
- bool is_mojo_enabled() const { return is_mojo_enabled_; }
void AssociateRendererProcessToPattern(const GURL& pattern) {
wrapper_->process_manager()->AddProcessReferenceToPattern(
@@ -435,7 +425,6 @@ class ServiceWorkerBrowserTest : public testing::WithParamInterface<bool>,
private:
scoped_refptr<ServiceWorkerContextWrapper> wrapper_;
- bool is_mojo_enabled_ = false;
};
class ConsoleListener : public EmbeddedWorkerInstance::Listener {

Powered by Google App Engine
This is Rietveld 408576698