Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2477213003: Reland of Unify some code (Closed)

Created:
4 years, 1 month ago by snake
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Reland of Unify some code Unify some code Move parsing of linearized header into separate CPDF_Linearized class. Original review: https://codereview.chromium.org/2466023002/ Revert review: https://codereview.chromium.org/2474283005/ Revert reason was: Breaking the chrome roll. See https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/331856 ___ Added Fix for fuzzers. Committed: https://pdfium.googlesource.com/pdfium/+/240dec52b2e6502e7deb27a3535af3b1a3e23428

Patch Set 1 #

Patch Set 2 : Fix fuzzers. #

Patch Set 3 : Fix fuzzers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -244 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M core/fpdfapi/parser/cpdf_data_avail.h View 3 chunks +2 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cpdf_data_avail.cpp View 13 chunks +33 lines, -114 lines 0 comments Download
M core/fpdfapi/parser/cpdf_document.h View 2 chunks +2 lines, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_document.cpp View 2 chunks +6 lines, -15 lines 0 comments Download
M core/fpdfapi/parser/cpdf_document_unittest.cpp View 3 chunks +10 lines, -5 lines 0 comments Download
M core/fpdfapi/parser/cpdf_hint_tables.h View 3 chunks +3 lines, -6 lines 0 comments Download
M core/fpdfapi/parser/cpdf_hint_tables.cpp View 3 chunks +10 lines, -22 lines 0 comments Download
A core/fpdfapi/parser/cpdf_linearized.h View 1 2 1 chunk +55 lines, -0 lines 0 comments Download
A core/fpdfapi/parser/cpdf_linearized.cpp View 1 2 1 chunk +71 lines, -0 lines 0 comments Download
M core/fpdfapi/parser/cpdf_parser.h View 3 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cpdf_parser.cpp View 7 chunks +13 lines, -33 lines 0 comments Download
M testing/libfuzzer/pdf_hint_table_fuzzer.cc View 1 2 chunks +41 lines, -42 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
snake
How I can build fuzzers locally or on try bots?
4 years, 1 month ago (2016-11-07 10:22:08 UTC) #3
dsinclair
On 2016/11/07 10:22:08, snake wrote: > How I can build fuzzers locally or on try ...
4 years, 1 month ago (2016-11-07 14:26:11 UTC) #8
dsinclair
lgtm
4 years, 1 month ago (2016-11-07 14:26:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477213003/20001
4 years, 1 month ago (2016-11-07 14:26:53 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/android/builds/1383) linux_xfa_asan_lsan on master.tryserver.client.pdfium (JOB_FAILED, ...
4 years, 1 month ago (2016-11-07 14:29:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477213003/40001
4 years, 1 month ago (2016-11-07 14:40:42 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477213003/40001
4 years, 1 month ago (2016-11-07 15:27:06 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 16:42:08 UTC) #21
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/240dec52b2e6502e7deb27a3535af3b1a3e2...

Powered by Google App Engine
This is Rietveld 408576698