third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp - Issue 2477203002: Media Controls: delegate 'volumechange' and 'focusin' handling to an EventListener.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

Issue 2477203002: Media Controls: delegate 'volumechange' and 'focusin' handling to an EventListener. (Closed)

Patch Set: add comment Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | third_party/WebKit/Source/core/html/shadow/MediaControls.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

index e60254555d49888e44e5603c68773519b13e9f57..5f4a1f06792dff6ac9b94b0f04a0abf3444344fc 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

@@ -299,7 +299,12 @@ void MediaControlMuteButtonElement::defaultEventHandler(Event* event) {

}

void MediaControlMuteButtonElement::updateDisplayType() {

- setDisplayType(mediaElement().muted() ? MediaUnMuteButton : MediaMuteButton);

+ // TODO(mlamouri): checking for volume == 0 because the mute button will look

+ // 'muted' when the volume is 0 even if the element is not muted. This allows

+ // the painting and the display type to actually match.

+ setDisplayType((mediaElement().muted() || mediaElement().volume() == 0)

+ ? MediaUnMuteButton

+ : MediaMuteButton);

updateOverflowString();

}