third_party/WebKit/LayoutTests/media/controls/volumechange-stopimmediatepropagation-expected.html - Issue 2477203002: Media Controls: delegate 'volumechange' and 'focusin' handling to an EventListener.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/controls/volumechange-stopimmediatepropagation-expected.html

Issue 2477203002: Media Controls: delegate 'volumechange' and 'focusin' handling to an EventListener. (Closed)

Patch Set: moar tests Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <script src="../media-file.js"></script>

	4 <div>

	5 <audio controls muted></audio>

	6 </div>

	7 <div>

	8 <video controls muted></video>

	9 </div>

	10 <div>

	11 <audio controls></audio> <!-- should be muted -->

	12 </div>

	13 <div>

	14 <video controls></video> <!-- should be muted -->

	15 </div>

	16 <script>

	17 var audios = document.querySelectorAll('audio');

	18 for (var i = 0; i < audios.length; ++i)

	19 audios[i].src = findMediaFile('audio', '../content/test');
	foolip 2016/11/14 16:07:37 I think this'll be fine, but make sure to run the I think this'll be fine, but make sure to run the tests many times to make sure it's not flaky. This depends on the window load event being delayed, which should work and guarantee that the first frame is decoded, but better safe than sorry. mlamouri (slow - plz ping) 2016/11/14 23:46:29 Ack. Ran 100 times both tests locally and no flake Show quoted text On 2016/11/14 at 16:07:37, foolip wrote: > I think this'll be fine, but make sure to run the tests many times to make sure it's not flaky. This depends on the window load event being delayed, which should work and guarantee that the first frame is decoded, but better safe than sorry. Ack. Ran 100 times both tests locally and no flake.
	20

	21 var videos = document.querySelectorAll('video');

	22 for (var i = 0; i < videos.length; ++i)

	23 videos[i].src = findMediaFile('video', '../content/test');

	24 </script>

	25 </html>

OLD	NEW