third_party/WebKit/LayoutTests/media/controls/volumechange-muted-attribute.html - Issue 2477203002: Media Controls: delegate 'volumechange' and 'focusin' handling to an EventListener.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/controls/volumechange-muted-attribute.html

Issue 2477203002: Media Controls: delegate 'volumechange' and 'focusin' handling to an EventListener. (Closed)

Patch Set: moar tests Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <title>This tests that controls are properly updated when muted content attribut e is changed.</title>

	4 <script src="../media-file.js"></script>

	5 <audio controls></audio>

	6 <video controls></video>

	7 <script>

	8 var audio = document.querySelector('audio');

	9 audio.setAttribute('muted', true);
	foolip 2016/11/14 16:07:37 Add a TODO that this is actually wrong per HTML, h Add a TODO that this is actually wrong per HTML, https://crbug.com/350303. Maybe we should change the spec to just set muted when the content attribute is added, but per current spec this should do nothing at all. mlamouri (slow - plz ping) 2016/11/14 23:46:29 Done. Show quoted text On 2016/11/14 at 16:07:37, foolip wrote: > Add a TODO that this is actually wrong per HTML, https://crbug.com/350303. Maybe we should change the spec to just set muted when the content attribute is added, but per current spec this should do nothing at all. Done.
	10 audio.src = findMediaFile('audio', '../content/test');

	11

	12 var video = document.querySelector('video');

	13 video.setAttribute('muted', true);

	14 video.src = findMediaFile('video', '../content/test');

	15 </script>

	16 </html>

OLD	NEW